From 8d738e4f74359924c09b6b7330062fe9ddcf63be Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Sun, 21 Feb 2021 22:58:59 -0500
Subject: [PATCH] Afform Admin - Ensure buttons have 'type' declared

---
 ext/afform/admin/ang/afAdmin/afAdminList.html                 | 2 +-
 ext/afform/admin/ang/afGuiEditor/elements/afGuiContainer.html | 2 +-
 ext/afform/admin/ang/afGuiEditor/saveBlock.html               | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ext/afform/admin/ang/afAdmin/afAdminList.html b/ext/afform/admin/ang/afAdmin/afAdminList.html
index ddcb6b1a68..c6ff0b7f86 100644
--- a/ext/afform/admin/ang/afAdmin/afAdminList.html
+++ b/ext/afform/admin/ang/afAdmin/afAdminList.html
@@ -14,7 +14,7 @@
       <a ng-if="types[$ctrl.tab].default" href="{{ types[$ctrl.tab].default }}" class="btn btn-primary">
         {{ ts('New %1', {1: types[$ctrl.tab].label }) }}
       </a>
-      <button ng-click="$ctrl.createLinks()" type="button" class="btn btn-primary dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+      <button type="button" ng-click="$ctrl.createLinks()" class="btn btn-primary dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
         <span ng-class="{'sr-only': types[$ctrl.tab].default}">{{ ts('New %1', {1: types[$ctrl.tab].label }) }}</span>
         <span class="caret"></span>
       </button>
diff --git a/ext/afform/admin/ang/afGuiEditor/elements/afGuiContainer.html b/ext/afform/admin/ang/afGuiEditor/elements/afGuiContainer.html
index ae6be1c806..e191239c0f 100644
--- a/ext/afform/admin/ang/afGuiEditor/elements/afGuiContainer.html
+++ b/ext/afform/admin/ang/afGuiEditor/elements/afGuiContainer.html
@@ -30,7 +30,7 @@
   </div>
 </div>
 <div ng-if="$ctrl.node['af-repeat'] || $ctrl.node['af-repeat'] === ''" class="af-gui-button">
-  <button class="btn btn-xs btn-primary disabled">
+  <button type="button" class="btn btn-xs btn-primary disabled">
     <span class="crm-editable-enabled" ng-click="pickAddIcon()" >
       <i class="crm-i {{ $ctrl.node['add-icon'] || 'fa-plus' }}"></i>
     </span>
diff --git a/ext/afform/admin/ang/afGuiEditor/saveBlock.html b/ext/afform/admin/ang/afGuiEditor/saveBlock.html
index a0efc242fd..ff119a3945 100644
--- a/ext/afform/admin/ang/afGuiEditor/saveBlock.html
+++ b/ext/afform/admin/ang/afGuiEditor/saveBlock.html
@@ -23,8 +23,8 @@
     </div>
     <hr />
     <div class="buttons pull-right">
-      <button ng-click="save()" class="btn btn-primary" ng-disabled="!model.title">{{:: ts('Save') }}</button>
-      <button ng-click="cancel()" class="btn btn-danger">{{:: ts('Cancel') }}</button>
+      <button type="submit" ng-click="save()" class="btn btn-primary" ng-disabled="!model.title">{{:: ts('Save') }}</button>
+      <button type="button" ng-click="cancel()" class="btn btn-danger">{{:: ts('Cancel') }}</button>
     </div>
   </div>
 </form>
-- 
2.25.1