From 8d5579e26d307be7ac4005591fd98a1551d9fda6 Mon Sep 17 00:00:00 2001 From: Kurund Jalmi Date: Fri, 5 Jul 2013 04:07:58 +0530 Subject: [PATCH] clean and notice fixes CRM-12966 --- CRM/Badge/BAO/Badge.php | 20 ++++++++++++++------ CRM/Event/Form/Task/Badge.php | 27 +++++++++++++++------------ 2 files changed, 29 insertions(+), 18 deletions(-) diff --git a/CRM/Badge/BAO/Badge.php b/CRM/Badge/BAO/Badge.php index 19bf2aa38b..821813ba26 100644 --- a/CRM/Badge/BAO/Badge.php +++ b/CRM/Badge/BAO/Badge.php @@ -86,10 +86,13 @@ class CRM_Badge_BAO_Badge { if (CRM_Utils_Array::value('rowElements', $layout['data'])) { foreach($layout['data']['rowElements'] as $key => $element) { - $value = $row[$element]; - // hack to fix date field display format - if (strpos($element,'_date')) { - $value = CRM_Utils_Date::customFormat($value, "%e %b"); + $value = ''; + if ($element) { + $value = $row[$element]; + // hack to fix date field display format + if (strpos($element, '_date')) { + $value = CRM_Utils_Date::customFormat($value, "%e %b"); + } } $formattedRow['token'][$key] = array( @@ -131,8 +134,13 @@ class CRM_Badge_BAO_Badge { $x = $this->pdf->GetAbsX(); $y = $this->pdf->GetY(); - $this->printImage($formattedRow['image_1']); - //$this->printImage($formattedRow['image_2']); + if (CRM_Utils_Array::value('image_1', $formattedRow)) { + $this->printImage($formattedRow['image_1']); + } + + if (CRM_Utils_Array::value('image_2', $formattedRow)) { + //$this->printImage($formattedRow['image_2']); + } $this->pdf->SetLineStyle(array('width' => 0.1, 'cap' => 'round', 'join' => 'round', 'dash' => '2,2', 'color' => array(0, 0, 200))); diff --git a/CRM/Event/Form/Task/Badge.php b/CRM/Event/Form/Task/Badge.php index 403c80f331..bc748ca228 100644 --- a/CRM/Event/Form/Task/Badge.php +++ b/CRM/Event/Form/Task/Badge.php @@ -118,20 +118,23 @@ class CRM_Event_Form_Task_Badge extends CRM_Event_Form_Task { $returnProperties = array(); if (!empty($layoutInfo['data']['token'])) { foreach ($layoutInfo['data']['token'] as $index => $value) { - $token = CRM_Utils_Token::getTokens($value); - if (key($token) == 'contact') { - $element = $token['contact'][0]; - } - else { - $element = $token['event'][0]; - //FIX ME - we need to standardize event token names - if (!strpos($element, 'event_')) { - $element = 'event_' .$element; + $element = ''; + if ($value) { + $token = CRM_Utils_Token::getTokens($value); + if (key($token) == 'contact') { + $element = $token['contact'][0]; + } + else { + $element = $token['event'][0]; + //FIX ME - we need to standardize event token names + if (!strpos($element, 'event_')) { + $element = 'event_' . $element; + } } - } - // build returnproperties for query - $returnProperties[$element] = 1; + // build returnproperties for query + $returnProperties[$element] = 1; + } // add actual field name to row element $layoutInfo['data']['rowElements'][$index] = $element; -- 2.25.1