From 8a76e0df2748a8d112f1a5d48a96eafc163acad8 Mon Sep 17 00:00:00 2001
From: Seamus Lee <seamuslee001@gmail.com>
Date: Tue, 8 Jun 2021 00:59:14 +0000
Subject: [PATCH] [php8-compact] Add in guards into common templates to assit
 with fixing test failures on php8

---
 templates/CRM/Core/Form/Field.tpl        | 10 +++++-----
 templates/CRM/Form/validate.tpl          |  2 +-
 templates/CRM/common/Tagset.tpl          |  8 +++++---
 templates/CRM/common/WizardHeader.tpl    |  6 +++---
 templates/CRM/common/customData.tpl      |  8 ++++----
 templates/CRM/common/customDataBlock.tpl |  2 +-
 templates/CRM/common/formButtons.tpl     |  2 +-
 templates/CRM/common/jsortable.tpl       |  2 +-
 templates/CRM/common/showHide.tpl        |  2 +-
 9 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/templates/CRM/Core/Form/Field.tpl b/templates/CRM/Core/Form/Field.tpl
index d8b8ea42fc..1d59c0e3c3 100644
--- a/templates/CRM/Core/Form/Field.tpl
+++ b/templates/CRM/Core/Form/Field.tpl
@@ -7,18 +7,18 @@
  | and copyright information, see https://civicrm.org/licensing       |
  +--------------------------------------------------------------------+
 *}
-{if $fieldSpec.template}
+{if !empty($fieldSpec.template)}
   {include file=$fieldSpec.template}
 {else}
   <td class="label">{$form.$fieldName.label}
-    {if $fieldSpec.help}{assign var=help value=$fieldSpec.help}{capture assign=helpFile}{if $fieldSpec.help}
+    {if !empty($fieldSpec.help)}{assign var=help value=$fieldSpec.help}{capture assign=helpFile}{if $fieldSpec.help}
       {$fieldSpec.help}
     {else}''{/if}
     {/capture}{help id=$help.id file=$help.file}{/if}
     {if $action == 2 && $fieldSpec.is_add_translate_dialog}{include file='CRM/Core/I18n/Dialog.tpl' table=$entityTable field=$fieldName id=$entityID}{/if}
   </td>
-  <td>{$fieldSpec.pre_html_text}{if $form.$fieldName.html}{$form.$fieldName.html}{else}{$fieldSpec.place_holder}{/if}{$fieldSpec.post_html_text}<br />
-    {if $fieldSpec.description}<span class="description">{$fieldSpec.description}</span>{/if}
-    {if $fieldSpec.documentation_link}{docURL page=$fieldSpec.documentation_link.page resource=$fieldSpec.documentation_link.resource}{/if}
+  <td>{if !empty($fieldSpec.pre_html_text)}{$fieldSpec.pre_html_text}{/if}{if $form.$fieldName.html}{$form.$fieldName.html}{else}{$fieldSpec.place_holder}{/if}{if !empty($fieldSpec.post_html_text)}{$fieldSpec.post_html_text}{/if}<br />
+    {if !empty($fieldSpec.description)}<span class="description">{$fieldSpec.description}</span>{/if}
+    {if !empty($fieldSpec.documentation_link)}{docURL page=$fieldSpec.documentation_link.page resource=$fieldSpec.documentation_link.resource}{/if}
   </td>
 {/if}
diff --git a/templates/CRM/Form/validate.tpl b/templates/CRM/Form/validate.tpl
index 248c0b74ba..6212a41bd8 100644
--- a/templates/CRM/Form/validate.tpl
+++ b/templates/CRM/Form/validate.tpl
@@ -9,7 +9,7 @@
 *}
 {* Initialize jQuery validate on a form *}
 {* Extra params and functions may be added to the CRM.validate object before this template is loaded *}
-{if !$crm_form_validate_included and $smarty.get.snippet neq 'json' and $form and $form.formClass}
+{if empty($crm_form_validate_included) and !empty($smarty.get.snippet) and $smarty.get.snippet neq 'json' and !empty($form) and !empty($form.formClass)}
   {assign var=crm_form_validate_included value=1}
   {literal}
   <script type="text/javascript">
diff --git a/templates/CRM/common/Tagset.tpl b/templates/CRM/common/Tagset.tpl
index b9542431c2..4f79616305 100644
--- a/templates/CRM/common/Tagset.tpl
+++ b/templates/CRM/common/Tagset.tpl
@@ -10,10 +10,11 @@
 {if empty($tagsetType)}
   {assign var="tagsetType" value="contact"}
 {/if}
-{if $tableLayout}
+{if !empty($tableLayout)}
   <td colspan="2" class="crm-content-block">
     <table>
 {/if}
+   {if !empty($tagsetInfo)}
     {foreach from=$tagsetInfo.$tagsetType item=tagset}
       {assign var="elemName" value=$tagset.tagsetElementName}
       {if empty($tagsetElementName) or $tagsetElementName eq $elemName}
@@ -38,12 +39,13 @@
         {/if}
       {/if}
     {/foreach}
-{if $tableLayout}
+    {/if}
+{if !empty($tableLayout)}
     </table>
   </td>
 {/if}
 
-{if !$skipEntityAction and empty($form.frozen)}
+{if empty($skipEntityAction) and empty($form.frozen)}
   <script type="text/javascript">
     {* Add/remove entity tags via ajax api *}
     {literal}
diff --git a/templates/CRM/common/WizardHeader.tpl b/templates/CRM/common/WizardHeader.tpl
index 195ae651aa..01daa52446 100644
--- a/templates/CRM/common/WizardHeader.tpl
+++ b/templates/CRM/common/WizardHeader.tpl
@@ -10,7 +10,7 @@
 {if count( $wizard.steps ) > 1}
 {* wizard.style variable is passed by some Wizards to allow alternate styling for progress "bar". *}
 <div id="wizard-steps">
-   <ul class="wizard-bar{if $wizard.style.barClass}-{$wizard.style.barClass}{/if}">
+   <ul class="wizard-bar{if !empty($wizard.style.barClass)}-{$wizard.style.barClass}{/if}">
     {section name=step loop=$wizard.steps}
         {if count ( $wizard.steps ) > 5 }
             {* truncate step titles so header isn't too wide *}
@@ -19,7 +19,7 @@
             {assign var="title" value=$wizard.steps[step].title}
         {/if}
         {* Show each wizard link unless collapsed value is true. Also excluding quest app submit steps. Should create separate WizardHeader for Quest at some point.*}
-        {if !$wizard.steps[step].collapsed && $wizard.steps[step].name NEQ 'Submit' && $wizard.steps[step].name NEQ 'PartnerSubmit'}
+        {if empty($wizard.steps[step].collapsed) && !empty($wizard.steps[step].name) && $wizard.steps[step].name NEQ 'Submit' && $wizard.steps[step].name NEQ 'PartnerSubmit'}
             {assign var=i value=$smarty.section.step.iteration}
             {if $wizard.currentStepNumber > $wizard.steps[step].stepNumber}
                 {if $wizard.steps[step].step}
@@ -64,7 +64,7 @@
     {/section}
    </ul>
 </div>
-{if $wizard.style.showTitle}
+{if !empty($wizard.style.showTitle)}
     <h2>{$wizard.currentStepTitle} {ts 1=$wizard.currentStepNumber 2=$wizard.stepCount}(step %1 of %2){/ts}</h2>
 {/if}
 {/if}
diff --git a/templates/CRM/common/customData.tpl b/templates/CRM/common/customData.tpl
index f52607dafe..948d761786 100644
--- a/templates/CRM/common/customData.tpl
+++ b/templates/CRM/common/customData.tpl
@@ -36,16 +36,16 @@
       }
 
       {/literal}
-      {if $groupID}
+      {if !empty($groupID)}
         dataUrl += '&groupID=' + '{$groupID}';
       {/if}
-      {if $entityID}
+      {if !empty($entityID)}
         dataUrl += '&entityID=' + '{$entityID}';
       {/if}
-      {if $qfKey}
+      {if !empty($qfKey)}
         dataUrl += '&qf=' + '{$qfKey}';
       {/if}
-      {if $action}
+      {if !empty($action)}
         dataUrl += '&action=' + '{$action}';
       {/if}
       {literal}
diff --git a/templates/CRM/common/customDataBlock.tpl b/templates/CRM/common/customDataBlock.tpl
index ca3848df70..eb7c73ccd2 100644
--- a/templates/CRM/common/customDataBlock.tpl
+++ b/templates/CRM/common/customDataBlock.tpl
@@ -1,4 +1,4 @@
-{if $customDataType}
+{if !empty($customDataType)}
   <div id="customData"></div>
   {*include custom data js file*}
   {include file="CRM/common/customData.tpl"}
diff --git a/templates/CRM/common/formButtons.tpl b/templates/CRM/common/formButtons.tpl
index cd1fd010d9..f00a974783 100644
--- a/templates/CRM/common/formButtons.tpl
+++ b/templates/CRM/common/formButtons.tpl
@@ -30,7 +30,7 @@
 
 {foreach from=$form.buttons item=button key=key name=btns}
   {if $key|substring:0:4 EQ '_qf_'}
-    {if $location}
+    {if !empty($location)}
       {$form.buttons.$key.html|crmReplace:id:"$key-$location"}
     {else}
       {$form.buttons.$key.html}
diff --git a/templates/CRM/common/jsortable.tpl b/templates/CRM/common/jsortable.tpl
index e76d7793d3..efd1d1d13d 100644
--- a/templates/CRM/common/jsortable.tpl
+++ b/templates/CRM/common/jsortable.tpl
@@ -27,7 +27,7 @@
     }
 
     // for date sorting see http://wiki.civicrm.org/confluence/display/CRMDOC/Sorting+Date+Fields+in+dataTables+Widget
-    var useAjax = {/literal}{if $useAjax}1{else}0{/if}{literal},
+    var useAjax = {/literal}{if !empty($useAjax)}1{else}0{/if}{literal},
       sourceUrl = '',
       useClass  = 'display',
       tcount = 1,
diff --git a/templates/CRM/common/showHide.tpl b/templates/CRM/common/showHide.tpl
index e7bc67115c..b750893aca 100644
--- a/templates/CRM/common/showHide.tpl
+++ b/templates/CRM/common/showHide.tpl
@@ -12,5 +12,5 @@
     var showBlocks = new Array({$showBlocks});
     var hideBlocks = new Array({$hideBlocks});
 
-    on_load_init_blocks( showBlocks, hideBlocks{if $elemType EQ 'table-row'}, 'table-row'{/if} );
+    on_load_init_blocks( showBlocks, hideBlocks{if !empty($elemType) and $elemType EQ 'table-row'}, 'table-row'{/if} );
  </script>
-- 
2.25.1