From 87c5b5b481d9d5d29377264e9f83614f838efa18 Mon Sep 17 00:00:00 2001 From: eileen Date: Sat, 5 Sep 2020 16:03:30 +1200 Subject: [PATCH] Remove deprecated ids param --- CRM/Contribute/BAO/Contribution.php | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 2abaeb5b86..c97eec991b 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -84,22 +84,17 @@ class CRM_Contribute_BAO_Contribution extends CRM_Contribute_DAO_Contribution { * * @param array $params * (reference ) an assoc array of name/value pairs. - * @param array $ids - * The array that holds all the db ids. * * @return \CRM_Contribute_BAO_Contribution * @throws \CRM_Core_Exception * @throws \CiviCRM_API3_Exception */ - public static function add(&$params, $ids = []) { + public static function add(&$params) { if (empty($params)) { return NULL; } - if (!empty($ids)) { - CRM_Core_Error::deprecatedFunctionWarning('ids should not be passed into Contribution.add'); - } - //per http://wiki.civicrm.org/confluence/display/CRM/Database+layer we are moving away from $ids array - $contributionID = CRM_Utils_Array::value('contribution', $ids, CRM_Utils_Array::value('id', $params)); + + $contributionID = $params['id'] ?? NULL; $action = $contributionID ? 'edit' : 'create'; $duplicates = []; if (self::checkDuplicate($params, $duplicates, $contributionID)) { -- 2.25.1