From 874347bddd555e6e96f072dea3c191450ffdb411 Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Mon, 7 Oct 2013 15:28:41 +0100
Subject: [PATCH] CRM_Contact_BAO_Individual Code cleanup

---
 CRM/Contact/BAO/Individual.php | 29 +++++++++--------------------
 1 file changed, 9 insertions(+), 20 deletions(-)

diff --git a/CRM/Contact/BAO/Individual.php b/CRM/Contact/BAO/Individual.php
index f51d957f58..a9978bd8ab 100644
--- a/CRM/Contact/BAO/Individual.php
+++ b/CRM/Contact/BAO/Individual.php
@@ -60,8 +60,7 @@ class CRM_Contact_BAO_Individual extends CRM_Contact_DAO_Contact {
 
     // "null" value for example is passed by dedupe merge in order to empty.
     // Display name computation shouldn't consider such values.
-    foreach (array(
-      'first_name', 'middle_name', 'last_name', 'nick_name') as $displayField) {
+    foreach (array('first_name', 'middle_name', 'last_name', 'nick_name') as $displayField) {
       if (CRM_Utils_Array::value($displayField, $params) == "null") {
         $params[$displayField] = '';
       }
@@ -76,17 +75,12 @@ class CRM_Contact_BAO_Individual extends CRM_Contact_DAO_Contact {
     $suffix_id  = CRM_Utils_Array::value('suffix_id', $params, '');
 
     // get prefix and suffix names
-    $prefixes = CRM_Core_PseudoConstant::get('CRM_Contact_DAO_Contact', 'prefix_id');
-    $suffixes = CRM_Core_PseudoConstant::get('CRM_Contact_DAO_Contact', 'suffix_id');
-
     $prefix = $suffix = NULL;
     if ($prefix_id) {
-      $prefix = $prefixes[$prefix_id];
-      $params['individual_prefix'] = $prefix;
+      $params['individual_prefix'] = $prefix = CRM_Core_PseudoConstant::getLabel('CRM_Contact_DAO_Contact', 'prefix_id', $prefix_id);
     }
     if ($suffix_id) {
-      $suffix = $suffixes[$suffix_id];
-      $params['individual_suffix'] = $suffix;
+      $params['individual_suffix'] = $suffix = CRM_Core_PseudoConstant::getLabel('CRM_Contact_DAO_Contact', 'suffix_id', $suffix_id);
     }
 
     $params['is_deceased'] = CRM_Utils_Array::value('is_deceased', $params, FALSE);
@@ -101,8 +95,7 @@ class CRM_Contact_BAO_Individual extends CRM_Contact_DAO_Contact {
         //but if db having null value and params contain value, CRM-4330.
         $useDBNames = array();
 
-        foreach (array(
-          'last', 'middle', 'first', 'nick') as $name) {
+        foreach (array('last', 'middle', 'first', 'nick') as $name) {
           $dbName = "{$name}_name";
           $value = $individual->$dbName;
 
@@ -112,8 +105,7 @@ class CRM_Contact_BAO_Individual extends CRM_Contact_DAO_Contact {
           }
         }
 
-        foreach (array(
-          'prefix', 'suffix') as $name) {
+        foreach (array('prefix', 'suffix') as $name) {
           $dbName = "{$name}_id";
           $value = $individual->$dbName;
           if ($value && CRM_Utils_Array::value('preserveDBName', $params)) {
@@ -126,8 +118,7 @@ class CRM_Contact_BAO_Individual extends CRM_Contact_DAO_Contact {
         //2. lets get value from param if exists.
         //3. if not in params, lets get from db.
 
-        foreach (array(
-          'last', 'middle', 'first', 'nick') as $name) {
+        foreach (array('last', 'middle', 'first', 'nick') as $name) {
           $phpName = "{$name}Name";
           $dbName  = "{$name}_name";
           $value   = $individual->$dbName;
@@ -144,8 +135,7 @@ class CRM_Contact_BAO_Individual extends CRM_Contact_DAO_Contact {
           }
         }
 
-        foreach (array(
-          'prefix', 'suffix') as $name) {
+        foreach (array('prefix', 'suffix') as $name) {
           $phpName = $name;
           $dbName  = "{$name}_id";
           $vals    = "{$name}es";
@@ -178,8 +168,7 @@ class CRM_Contact_BAO_Individual extends CRM_Contact_DAO_Contact {
     }
 
     //first trim before further processing.
-    foreach (array(
-      'lastName', 'firstName', 'middleName') as $fld) {
+    foreach (array('lastName', 'firstName', 'middleName') as $fld) {
       $$fld = trim($$fld);
     }
 
@@ -206,7 +195,7 @@ class CRM_Contact_BAO_Individual extends CRM_Contact_DAO_Contact {
       $tokens = array();
       CRM_Utils_Hook::tokens($tokens);
       $tokenFields = array();
-      foreach ($tokens as $category => $catTokens) {
+      foreach ($tokens as $catTokens) {
         foreach ($catTokens as $token => $label) {
           $tokenFields[] = $token;
         }
-- 
2.25.1