From 873a978fddf9312f869d65b9e49fe9bd33ac76f3 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Mon, 19 Jun 2023 15:06:02 +1200 Subject: [PATCH] Remove remaining places where unused variable is passed --- CRM/Event/Form/ParticipantFeeSelection.php | 3 +-- CRM/Member/Form/Membership.php | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/CRM/Event/Form/ParticipantFeeSelection.php b/CRM/Event/Form/ParticipantFeeSelection.php index 883048922a..f0dcc7803f 100644 --- a/CRM/Event/Form/ParticipantFeeSelection.php +++ b/CRM/Event/Form/ParticipantFeeSelection.php @@ -246,8 +246,7 @@ class CRM_Event_Form_ParticipantFeeSelection extends CRM_Core_Form { $params = $this->controller->exportValues($this->_name); $feeBlock = $this->_values['fee']; - $lineItems = $this->_values['line_items']; - CRM_Price_BAO_LineItem::changeFeeSelections($params, $this->_participantId, 'participant', $this->getContributionID(), $feeBlock, $lineItems); + CRM_Price_BAO_LineItem::changeFeeSelections($params, $this->_participantId, 'participant', $this->getContributionID(), $feeBlock); $this->contributionAmt = CRM_Core_DAO::getFieldValue('CRM_Contribute_BAO_Contribution', $this->getContributionID(), 'total_amount'); // email sending if (!empty($params['send_receipt'])) { diff --git a/CRM/Member/Form/Membership.php b/CRM/Member/Form/Membership.php index 7c5fee3228..8f62191253 100644 --- a/CRM/Member/Form/Membership.php +++ b/CRM/Member/Form/Membership.php @@ -1395,8 +1395,6 @@ DESC limit 1"); return; } - // fetch lineitems by updated membership ID - $lineItems = CRM_Price_BAO_LineItem::getLineItems($this->getMembershipID(), 'membership'); // retrieve the related contribution ID $contributionID = CRM_Core_DAO::getFieldValue( 'CRM_Member_DAO_MembershipPayment', @@ -1423,8 +1421,7 @@ DESC limit 1"); $this->getMembershipID(), 'membership', $contributionID, - $priceSetDetails['fields'], - $lineItems + $priceSetDetails['fields'] ); CRM_Core_Session::setStatus(ts('Associated contribution is updated on membership type change.'), ts('Success'), 'success'); } -- 2.25.1