From 863fadaad3781cdab239bf6cba1dfdb412fb21c4 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Fri, 17 Jul 2015 15:23:30 +1200 Subject: [PATCH] phpcs fixes --- CRM/Contribute/BAO/Contribution/Utils.php | 1 - CRM/Core/Payment.php | 9 ++++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution/Utils.php b/CRM/Contribute/BAO/Contribution/Utils.php index 6e016da51e..687fe4150d 100644 --- a/CRM/Contribute/BAO/Contribution/Utils.php +++ b/CRM/Contribute/BAO/Contribution/Utils.php @@ -208,7 +208,6 @@ class CRM_Contribute_BAO_Contribution_Utils { $form->_values, $contribution->is_test ); - return; } /** diff --git a/CRM/Core/Payment.php b/CRM/Core/Payment.php index 860eaa3f67..6dbb4660a8 100644 --- a/CRM/Core/Payment.php +++ b/CRM/Core/Payment.php @@ -624,16 +624,15 @@ abstract class CRM_Core_Payment { * * Does a server to server payment transaction. * - * Note that doPayment will throw an exception so the code may need to be modified - * * @param array $params * Assoc array of input parameters for this transaction. * * @return array - * the result in an nice formatted array (or an error object) - * @abstract + * the result in an nice formatted array (or an error object - but throwing exceptions is preferred) */ - protected function doDirectPayment(&$params) {} + protected function doDirectPayment(&$params) { + return $params; + } /** * Process payment - this function wraps around both doTransferPayment and doDirectPayment. -- 2.25.1