From 85e3b778a5a07d62f5af6f7cac65265fc9ef24bc Mon Sep 17 00:00:00 2001 From: eileen Date: Mon, 12 Oct 2020 10:57:04 +1300 Subject: [PATCH] dev/core#2115 remove reference to financialACLs in bounce I believe that the other 2 criteria suffice. allMembershipDetails is built from CRM_Member_BAO_Membership::buildMembershipTypeValues() which is altered by financial acls but also potentially by other extensions so I don't think the bounce should be restricted to when financial acls are in play --- CRM/Member/Form/Membership.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CRM/Member/Form/Membership.php b/CRM/Member/Form/Membership.php index cedf8eed66..b249c08180 100644 --- a/CRM/Member/Form/Membership.php +++ b/CRM/Member/Form/Membership.php @@ -470,8 +470,7 @@ class CRM_Member_Form_Membership extends CRM_Member_Form { $selOrgMemType[0][0] = $selMemTypeOrg[0] = ts('- select -'); // Throw status bounce when no Membership type or priceset is present - if (CRM_Financial_BAO_FinancialType::isACLFinancialTypeStatus() - && empty($this->allMembershipTypeDetails) && empty($priceSets) + if (empty($this->allMembershipTypeDetails) && empty($priceSets) ) { CRM_Core_Error::statusBounce(ts('You do not have all the permissions needed for this page.')); } -- 2.25.1