From 8472d3c37416a6e13c55e811304a33a43ecc28a8 Mon Sep 17 00:00:00 2001 From: Johan Vervloet Date: Tue, 23 Jun 2015 19:35:12 +0200 Subject: [PATCH] CRM-16701 - test for form_values before copying it to formValues. Otherwise things go wrong when calling create to update a field and leaving form_values untouched. ---------------------------------------- * CRM-16701: Create API for saved searches https://issues.civicrm.org/jira/browse/CRM-16701 --- api/v3/SavedSearch.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/api/v3/SavedSearch.php b/api/v3/SavedSearch.php index 6048aedcb9..c502ef9a1a 100644 --- a/api/v3/SavedSearch.php +++ b/api/v3/SavedSearch.php @@ -49,12 +49,14 @@ function civicrm_api3_saved_search_create($params) { // So for the create API, I guess it should work for serialized and // unserialized form_values. - if (is_array($params["form_values"])) { - $params["formValues"] = $params["form_values"]; - } - else { - // Assume that form_values is serialized. - $params["formValues"] = unserialize($params["form_values"]); + if (isset($params["form_values"])) { + if (is_array($params["form_values"])) { + $params["formValues"] = $params["form_values"]; + } + else { + // Assume that form_values is serialized. + $params["formValues"] = unserialize($params["form_values"]); + } } $result = _civicrm_api3_basic_create(_civicrm_api3_get_BAO(__FUNCTION__), $params); -- 2.25.1