From 80d51c38f17314bc3668e7fc77b3b129c0418989 Mon Sep 17 00:00:00 2001 From: Seamus Lee Date: Fri, 29 May 2020 16:43:36 +1000 Subject: [PATCH] [REF] Refactor to switch from pear HTTP Request class to using Guzzle --- CRM/Utils/Address/USPS.php | 20 +++++++++----------- CRM/Utils/Geocode/Google.php | 7 +++---- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/CRM/Utils/Address/USPS.php b/CRM/Utils/Address/USPS.php index bba6d337a9..721b2e70e0 100644 --- a/CRM/Utils/Address/USPS.php +++ b/CRM/Utils/Address/USPS.php @@ -68,19 +68,17 @@ class CRM_Utils_Address_USPS { $XMLQuery = '
' . CRM_Utils_Array::value('supplemental_address_1', $values, '') . '' . $address2 . '' . $values['city'] . '' . $values['state_province'] . '' . $values['postal_code'] . '' . CRM_Utils_Array::value('postal_code_suffix', $values, '') . '
'; - require_once 'HTTP/Request.php'; - $request = new HTTP_Request(); - - $request->setURL($url); - - $request->addQueryString('API', 'Verify'); - $request->addQueryString('XML', $XMLQuery); - - $response = $request->sendRequest(); + $client = new GuzzleHttp\Client(); + $request = $client->request('GET', $url, [ + 'query' => [ + 'API' => 'Verify', + 'XML' => $XMLQuery, + ], + ]); $session = CRM_Core_Session::singleton(); - $code = $request->getResponseCode(); + $code = $request->getStatusCode(); if ($code != 200) { $session->setStatus(ts('USPS Address Lookup Failed with HTTP status code: %1', [1 => $code] @@ -88,7 +86,7 @@ class CRM_Utils_Address_USPS { return FALSE; } - $responseBody = $request->getResponseBody(); + $responseBody = $request->getBody(); $xml = simplexml_load_string($responseBody); diff --git a/CRM/Utils/Geocode/Google.php b/CRM/Utils/Geocode/Google.php index 1cb0c847ca..6ab1397fea 100644 --- a/CRM/Utils/Geocode/Google.php +++ b/CRM/Utils/Geocode/Google.php @@ -105,10 +105,9 @@ class CRM_Utils_Geocode_Google { $query = 'https://' . self::$_server . self::$_uri . $add; - require_once 'HTTP/Request.php'; - $request = new HTTP_Request($query); - $request->sendRequest(); - $string = $request->getResponseBody(); + $client = new GuzzleHttp\Client(); + $request = $client->request('GET', $query); + $string = $request->getBody(); libxml_use_internal_errors(TRUE); $xml = @simplexml_load_string($string); -- 2.25.1