From 804112adbf98fa018c452afe86cf694978a5b7d1 Mon Sep 17 00:00:00 2001
From: colemanw <coleman@civicrm.org>
Date: Mon, 11 Sep 2023 21:45:41 -0400
Subject: [PATCH] Metadata - Add "civicrm_note" to "note_used_for" option group

---
 CRM/Upgrade/Incremental/php/FiveSixtySeven.php        | 11 +++++++++++
 .../civicrm_option_group/note_used_for.sqldata.php    |  2 ++
 2 files changed, 13 insertions(+)

diff --git a/CRM/Upgrade/Incremental/php/FiveSixtySeven.php b/CRM/Upgrade/Incremental/php/FiveSixtySeven.php
index 71a2ae32c7..0745dab82b 100644
--- a/CRM/Upgrade/Incremental/php/FiveSixtySeven.php
+++ b/CRM/Upgrade/Incremental/php/FiveSixtySeven.php
@@ -32,6 +32,17 @@ class CRM_Upgrade_Incremental_php_FiveSixtySeven extends CRM_Upgrade_Incremental
     $this->addTask('Make EntityFile.entity_table required', 'alterColumn', 'civicrm_entity_file', 'entity_table', "varchar(64) NOT NULL COMMENT 'physical tablename for entity being joined to file, e.g. civicrm_contact'");
     $this->addExtensionTask('Enable Authx extension', ['authx'], 1101);
     $this->addExtensionTask('Enable Afform extension', ['org.civicrm.afform'], 1102);
+    $this->addTask('Add "civicrm_note" to "note_used_for" option group', 'addNoteNote');
+  }
+
+  public static function addNoteNote(CRM_Queue_TaskContext $ctx): bool {
+    CRM_Core_BAO_OptionValue::ensureOptionValueExists([
+      'option_group_id' => 'note_used_for',
+      'label' => ts('Notes'),
+      'name' => 'Note',
+      'value' => 'civicrm_note',
+    ]);
+    return TRUE;
   }
 
 }
diff --git a/sql/civicrm_data/civicrm_option_group/note_used_for.sqldata.php b/sql/civicrm_data/civicrm_option_group/note_used_for.sqldata.php
index a3ed714dcc..f36eb93f20 100644
--- a/sql/civicrm_data/civicrm_option_group/note_used_for.sqldata.php
+++ b/sql/civicrm_data/civicrm_option_group/note_used_for.sqldata.php
@@ -9,4 +9,6 @@ return CRM_Core_CodeGen_OptionGroup::create('note_used_for', 'a/0047')
     [ts('Relationships'), 'Relationship', 'civicrm_relationship'],
     [ts('Participants'), 'Participant', 'civicrm_participant'],
     [ts('Contributions'), 'Contribution', 'civicrm_contribution'],
+    // Notes can be attached to notes as comments
+    [ts('Notes'), 'Note', 'civicrm_note'],
   ]);
-- 
2.25.1