From 7ef12efccaffd9a41c3a2a03349fc486dfa1b877 Mon Sep 17 00:00:00 2001 From: eileen Date: Fri, 26 Mar 2021 09:27:46 +1300 Subject: [PATCH] Add void to some setup() functions --- tests/phpunit/api/v3/ACLCachingTest.php | 2 +- tests/phpunit/api/v3/ACLPermissionTest.php | 2 +- tests/phpunit/api/v3/ActionScheduleTest.php | 2 +- tests/phpunit/api/v3/ActivityCaseTest.php | 2 +- tests/phpunit/api/v3/ActivityContactTest.php | 2 +- tests/phpunit/api/v3/ActivityTypeTest.php | 2 +- tests/phpunit/api/v3/AddressTest.php | 2 +- tests/phpunit/api/v3/AttachmentTest.php | 2 +- tests/phpunit/api/v3/BatchTest.php | 2 +- tests/phpunit/api/v3/CRM11793Test.php | 2 +- tests/phpunit/api/v3/CampaignTest.php | 2 +- tests/phpunit/api/v3/CaseContactTest.php | 2 +- tests/phpunit/api/v3/CaseTest.php | 2 +- tests/phpunit/api/v3/CaseTypeTest.php | 2 +- tests/phpunit/api/v3/ConstantTest.php | 2 +- tests/phpunit/api/v3/ContactTypeTest.php | 2 +- tests/phpunit/api/v3/ContributionPageTest.php | 2 +- tests/phpunit/api/v3/ContributionRecurTest.php | 2 +- tests/phpunit/api/v3/ContributionSoftTest.php | 2 +- tests/phpunit/api/v3/ContributionTest.php | 2 +- tests/phpunit/api/v3/CountryTest.php | 2 +- tests/phpunit/api/v3/CustomApiTest.php | 2 +- tests/phpunit/api/v3/CustomGroupTest.php | 2 +- tests/phpunit/api/v3/CustomSearchTest.php | 2 +- tests/phpunit/api/v3/CustomValueContactTypeTest.php | 2 +- tests/phpunit/api/v3/CustomValueTest.php | 4 ---- tests/phpunit/api/v3/DashboardContactTest.php | 2 +- tests/phpunit/api/v3/DashboardTest.php | 2 +- tests/phpunit/api/v3/DomainTest.php | 2 +- tests/phpunit/api/v3/EmailTest.php | 2 +- tests/phpunit/api/v3/EntityBatchTest.php | 2 +- tests/phpunit/api/v3/EntityJoinTest.php | 2 +- tests/phpunit/api/v3/EntityTagACLTest.php | 2 +- tests/phpunit/api/v3/EntityTagTest.php | 2 +- tests/phpunit/api/v3/EventTest.php | 2 +- tests/phpunit/api/v3/ExceptionTest.php | 2 +- tests/phpunit/api/v3/ExtensionTest.php | 2 +- tests/phpunit/api/v3/FinancialTypeACLTest.php | 2 +- tests/phpunit/api/v3/GrantTest.php | 2 +- tests/phpunit/api/v3/GroupContactTest.php | 2 +- tests/phpunit/api/v3/GroupNestingTest.php | 2 +- tests/phpunit/api/v3/GroupOrganizationTest.php | 2 +- tests/phpunit/api/v3/ImTest.php | 2 +- tests/phpunit/api/v3/JobProcessMailingTest.php | 2 +- tests/phpunit/api/v3/JobProcessMembershipTest.php | 2 +- tests/phpunit/api/v3/JobTestCustomDataTest.php | 2 +- tests/phpunit/api/v3/LineItemTest.php | 2 +- tests/phpunit/api/v3/LocBlockTest.php | 2 +- tests/phpunit/api/v3/LoggingTest.php | 2 +- tests/phpunit/api/v3/MailSettingsTest.php | 2 +- tests/phpunit/api/v3/MailingABTest.php | 2 +- tests/phpunit/api/v3/MailingContactTest.php | 2 +- tests/phpunit/api/v3/MailingGroupTest.php | 2 +- 53 files changed, 52 insertions(+), 56 deletions(-) diff --git a/tests/phpunit/api/v3/ACLCachingTest.php b/tests/phpunit/api/v3/ACLCachingTest.php index 5c0bc7f5d3..d5e1154040 100644 --- a/tests/phpunit/api/v3/ACLCachingTest.php +++ b/tests/phpunit/api/v3/ACLCachingTest.php @@ -21,7 +21,7 @@ class api_v3_ACLCachingTest extends CiviUnitTestCase { public $DBResetRequired = FALSE; - public function setUp() { + public function setUp(): void { parent::setUp(); } diff --git a/tests/phpunit/api/v3/ACLPermissionTest.php b/tests/phpunit/api/v3/ACLPermissionTest.php index b31278c940..61887fcabc 100644 --- a/tests/phpunit/api/v3/ACLPermissionTest.php +++ b/tests/phpunit/api/v3/ACLPermissionTest.php @@ -28,7 +28,7 @@ class api_v3_ACLPermissionTest extends CiviUnitTestCase { public $DBResetRequired = FALSE; protected $_entity; - public function setUp() { + public function setUp(): void { parent::setUp(); CRM_Core_DAO::createTestObject('CRM_Pledge_BAO_Pledge', [], 1, 0); $this->callAPISuccess('Phone', 'create', ['id' => $this->individualCreate(['email' => '']), 'phone' => '911', 'location_type_id' => 'Home']); diff --git a/tests/phpunit/api/v3/ActionScheduleTest.php b/tests/phpunit/api/v3/ActionScheduleTest.php index 8c3a4e1192..28abe07070 100644 --- a/tests/phpunit/api/v3/ActionScheduleTest.php +++ b/tests/phpunit/api/v3/ActionScheduleTest.php @@ -39,7 +39,7 @@ class api_v3_ActionScheduleTest extends CiviUnitTestCase { /** * Test setup for every test. */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); } diff --git a/tests/phpunit/api/v3/ActivityCaseTest.php b/tests/phpunit/api/v3/ActivityCaseTest.php index 4bba2e4a81..81a9b4b42d 100644 --- a/tests/phpunit/api/v3/ActivityCaseTest.php +++ b/tests/phpunit/api/v3/ActivityCaseTest.php @@ -29,7 +29,7 @@ class api_v3_ActivityCaseTest extends CiviCaseTestCase { * Connect to the database, truncate the tables that will be used * and redirect stdin to a temporary file. */ - public function setUp() { + public function setUp(): void { $this->_entity = 'case'; parent::setUp(); diff --git a/tests/phpunit/api/v3/ActivityContactTest.php b/tests/phpunit/api/v3/ActivityContactTest.php index 73d690f32f..4f721843c4 100644 --- a/tests/phpunit/api/v3/ActivityContactTest.php +++ b/tests/phpunit/api/v3/ActivityContactTest.php @@ -23,7 +23,7 @@ class api_v3_ActivityContactTest extends CiviUnitTestCase { protected $_activityID; protected $_params; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/ActivityTypeTest.php b/tests/phpunit/api/v3/ActivityTypeTest.php index 9fbf0bba9c..0af2b1ab3c 100644 --- a/tests/phpunit/api/v3/ActivityTypeTest.php +++ b/tests/phpunit/api/v3/ActivityTypeTest.php @@ -34,7 +34,7 @@ class api_v3_ActivityTypeTest extends CiviUnitTestCase { protected $_apiversion; - public function setUp() { + public function setUp(): void { $this->_apiversion = 3; CRM_Core_PseudoConstant::activityType(TRUE, TRUE, TRUE, 'name'); parent::setUp(); diff --git a/tests/phpunit/api/v3/AddressTest.php b/tests/phpunit/api/v3/AddressTest.php index 83646351d8..69817d4bfd 100644 --- a/tests/phpunit/api/v3/AddressTest.php +++ b/tests/phpunit/api/v3/AddressTest.php @@ -27,7 +27,7 @@ class api_v3_AddressTest extends CiviUnitTestCase { protected $_entity; - public function setUp() { + public function setUp(): void { $this->_entity = 'Address'; parent::setUp(); diff --git a/tests/phpunit/api/v3/AttachmentTest.php b/tests/phpunit/api/v3/AttachmentTest.php index b13295dd25..151b4de8f4 100644 --- a/tests/phpunit/api/v3/AttachmentTest.php +++ b/tests/phpunit/api/v3/AttachmentTest.php @@ -45,7 +45,7 @@ class api_v3_AttachmentTest extends CiviUnitTestCase { return self::$filePrefix; } - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/BatchTest.php b/tests/phpunit/api/v3/BatchTest.php index 1fe4376584..457abcd2d6 100644 --- a/tests/phpunit/api/v3/BatchTest.php +++ b/tests/phpunit/api/v3/BatchTest.php @@ -25,7 +25,7 @@ class api_v3_BatchTest extends CiviUnitTestCase { * * This method is called before a test is executed. */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); } diff --git a/tests/phpunit/api/v3/CRM11793Test.php b/tests/phpunit/api/v3/CRM11793Test.php index f5bbbdda47..e1a5a5b6eb 100644 --- a/tests/phpunit/api/v3/CRM11793Test.php +++ b/tests/phpunit/api/v3/CRM11793Test.php @@ -18,7 +18,7 @@ class api_v3_CRM11793Test extends CiviUnitTestCase { * Connect to the database, truncate the tables that will be used * and redirect stdin to a temporary file */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->individualCreate(); diff --git a/tests/phpunit/api/v3/CampaignTest.php b/tests/phpunit/api/v3/CampaignTest.php index e7be699615..7f32427506 100644 --- a/tests/phpunit/api/v3/CampaignTest.php +++ b/tests/phpunit/api/v3/CampaignTest.php @@ -19,7 +19,7 @@ class api_v3_CampaignTest extends CiviUnitTestCase { public $DBResetRequired = FALSE; - public function setUp() { + public function setUp(): void { $this->params = [ 'title' => "campaign title", 'description' => "Call people, ask for money", diff --git a/tests/phpunit/api/v3/CaseContactTest.php b/tests/phpunit/api/v3/CaseContactTest.php index b65cf541e4..802bcdb30a 100644 --- a/tests/phpunit/api/v3/CaseContactTest.php +++ b/tests/phpunit/api/v3/CaseContactTest.php @@ -23,7 +23,7 @@ class api_v3_CaseContactTest extends CiviCaseTestCase { * Connect to the database, truncate the tables that will be used * and redirect stdin to a temporary file. */ - public function setUp() { + public function setUp(): void { $this->_entity = 'case'; parent::setUp(); diff --git a/tests/phpunit/api/v3/CaseTest.php b/tests/phpunit/api/v3/CaseTest.php index edeb4739d5..a172c07bed 100644 --- a/tests/phpunit/api/v3/CaseTest.php +++ b/tests/phpunit/api/v3/CaseTest.php @@ -58,7 +58,7 @@ class api_v3_CaseTest extends CiviCaseTestCase { * Connect to the database, truncate the tables that will be used * and redirect stdin to a temporary file. */ - public function setUp() { + public function setUp(): void { $this->_entity = 'case'; parent::setUp(); diff --git a/tests/phpunit/api/v3/CaseTypeTest.php b/tests/phpunit/api/v3/CaseTypeTest.php index 5dfac71056..5421b1f47e 100644 --- a/tests/phpunit/api/v3/CaseTypeTest.php +++ b/tests/phpunit/api/v3/CaseTypeTest.php @@ -15,7 +15,7 @@ */ class api_v3_CaseTypeTest extends CiviCaseTestCase { - public function setUp() { + public function setUp(): void { $this->quickCleanup(['civicrm_case_type']); parent::setUp(); diff --git a/tests/phpunit/api/v3/ConstantTest.php b/tests/phpunit/api/v3/ConstantTest.php index cc000f719b..09aea87e61 100644 --- a/tests/phpunit/api/v3/ConstantTest.php +++ b/tests/phpunit/api/v3/ConstantTest.php @@ -44,7 +44,7 @@ class api_v3_ConstantTest extends CiviUnitTestCase { * Connect to the database, truncate the tables that will be used * and redirect stdin to a temporary file */ - public function setUp() { + public function setUp(): void { // Connect to the database parent::setUp(); } diff --git a/tests/phpunit/api/v3/ContactTypeTest.php b/tests/phpunit/api/v3/ContactTypeTest.php index fa69185aca..fe34b4d731 100644 --- a/tests/phpunit/api/v3/ContactTypeTest.php +++ b/tests/phpunit/api/v3/ContactTypeTest.php @@ -16,7 +16,7 @@ class api_v3_ContactTypeTest extends CiviUnitTestCase { protected $_apiversion; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); $params = [ diff --git a/tests/phpunit/api/v3/ContributionPageTest.php b/tests/phpunit/api/v3/ContributionPageTest.php index f4b4562ef1..e7f14a6d81 100644 --- a/tests/phpunit/api/v3/ContributionPageTest.php +++ b/tests/phpunit/api/v3/ContributionPageTest.php @@ -54,7 +54,7 @@ class api_v3_ContributionPageTest extends CiviUnitTestCase { * * @throws \CRM_Core_Exception */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->contactIds[] = $this->individualCreate(); $this->params = [ diff --git a/tests/phpunit/api/v3/ContributionRecurTest.php b/tests/phpunit/api/v3/ContributionRecurTest.php index 551f43ec11..2f7f6b5bf7 100644 --- a/tests/phpunit/api/v3/ContributionRecurTest.php +++ b/tests/phpunit/api/v3/ContributionRecurTest.php @@ -25,7 +25,7 @@ class api_v3_ContributionRecurTest extends CiviUnitTestCase { /** * @throws \CRM_Core_Exception */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(); $this->ids['contact'][0] = $this->individualCreate(); diff --git a/tests/phpunit/api/v3/ContributionSoftTest.php b/tests/phpunit/api/v3/ContributionSoftTest.php index 6880605e79..a7fad26a98 100644 --- a/tests/phpunit/api/v3/ContributionSoftTest.php +++ b/tests/phpunit/api/v3/ContributionSoftTest.php @@ -45,7 +45,7 @@ class api_v3_ContributionSoftTest extends CiviUnitTestCase { public $debug = 0; protected $_params; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/ContributionTest.php b/tests/phpunit/api/v3/ContributionTest.php index 3a01ca7820..082b5d0f57 100644 --- a/tests/phpunit/api/v3/ContributionTest.php +++ b/tests/phpunit/api/v3/ContributionTest.php @@ -62,7 +62,7 @@ class api_v3_ContributionTest extends CiviUnitTestCase { * * @throws \CRM_Core_Exception */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->_apiversion = 3; diff --git a/tests/phpunit/api/v3/CountryTest.php b/tests/phpunit/api/v3/CountryTest.php index c0d82cfed1..982c49ea20 100644 --- a/tests/phpunit/api/v3/CountryTest.php +++ b/tests/phpunit/api/v3/CountryTest.php @@ -19,7 +19,7 @@ class api_v3_CountryTest extends CiviUnitTestCase { protected $_params; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); $this->_params = [ diff --git a/tests/phpunit/api/v3/CustomApiTest.php b/tests/phpunit/api/v3/CustomApiTest.php index 6a2849b766..1ff5095861 100644 --- a/tests/phpunit/api/v3/CustomApiTest.php +++ b/tests/phpunit/api/v3/CustomApiTest.php @@ -19,7 +19,7 @@ class api_v3_CustomApiTest extends CiviUnitTestCase { protected $_apiversion = 3; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->installApi(); } diff --git a/tests/phpunit/api/v3/CustomGroupTest.php b/tests/phpunit/api/v3/CustomGroupTest.php index 03cb6a85d0..e689a66bf4 100644 --- a/tests/phpunit/api/v3/CustomGroupTest.php +++ b/tests/phpunit/api/v3/CustomGroupTest.php @@ -23,7 +23,7 @@ class api_v3_CustomGroupTest extends CiviUnitTestCase { public $DBResetRequired = TRUE; - public function setUp() { + public function setUp(): void { $this->_entity = 'CustomGroup'; $this->_params = [ 'title' => 'Test_Group_1', diff --git a/tests/phpunit/api/v3/CustomSearchTest.php b/tests/phpunit/api/v3/CustomSearchTest.php index 4ac288050b..8c73a3c1d1 100644 --- a/tests/phpunit/api/v3/CustomSearchTest.php +++ b/tests/phpunit/api/v3/CustomSearchTest.php @@ -7,7 +7,7 @@ class api_v3_CustomSearchTest extends CiviUnitTestCase { protected $_apiversion; - public function setUp() { + public function setUp(): void { $this->_apiversion = 3; parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/CustomValueContactTypeTest.php b/tests/phpunit/api/v3/CustomValueContactTypeTest.php index 2f012d9585..238104895f 100644 --- a/tests/phpunit/api/v3/CustomValueContactTypeTest.php +++ b/tests/phpunit/api/v3/CustomValueContactTypeTest.php @@ -22,7 +22,7 @@ class api_v3_CustomValueContactTypeTest extends CiviUnitTestCase { protected $CustomGroupIndividual; protected $individualStudent; - public function setUp() { + public function setUp(): void { parent::setUp(); // Create Group For Individual Contact Type $groupIndividual = [ diff --git a/tests/phpunit/api/v3/CustomValueTest.php b/tests/phpunit/api/v3/CustomValueTest.php index 6e54accb50..78511ade3b 100644 --- a/tests/phpunit/api/v3/CustomValueTest.php +++ b/tests/phpunit/api/v3/CustomValueTest.php @@ -21,10 +21,6 @@ class api_v3_CustomValueTest extends CiviUnitTestCase { public $DBResetRequired = FALSE; - public function setUp() { - parent::setUp(); - } - public function _populateOptionAndCustomGroup($type = NULL) { $dataValues = [ 'integer' => [1, 2, 3], diff --git a/tests/phpunit/api/v3/DashboardContactTest.php b/tests/phpunit/api/v3/DashboardContactTest.php index e5b0728d16..9c86fd1984 100644 --- a/tests/phpunit/api/v3/DashboardContactTest.php +++ b/tests/phpunit/api/v3/DashboardContactTest.php @@ -38,7 +38,7 @@ class api_v3_DashboardContactTest extends CiviUnitTestCase { * Connect to the database, truncate the tables that will be used * and redirect stdin to a temporary file */ - public function setUp() { + public function setUp(): void { // Connect to the database parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/DashboardTest.php b/tests/phpunit/api/v3/DashboardTest.php index 3a21ceff8d..d9e1f30a19 100644 --- a/tests/phpunit/api/v3/DashboardTest.php +++ b/tests/phpunit/api/v3/DashboardTest.php @@ -38,7 +38,7 @@ class api_v3_DashboardTest extends CiviUnitTestCase { * Connect to the database, truncate the tables that will be used * and redirect stdin to a temporary file */ - public function setUp() { + public function setUp(): void { // Connect to the database parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/DomainTest.php b/tests/phpunit/api/v3/DomainTest.php index 2a0d2caea7..bb9eb817c8 100644 --- a/tests/phpunit/api/v3/DomainTest.php +++ b/tests/phpunit/api/v3/DomainTest.php @@ -32,7 +32,7 @@ class api_v3_DomainTest extends CiviUnitTestCase { * * This method is called before a test is executed. */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/EmailTest.php b/tests/phpunit/api/v3/EmailTest.php index 1de8dbf9fd..549e6ba1fc 100644 --- a/tests/phpunit/api/v3/EmailTest.php +++ b/tests/phpunit/api/v3/EmailTest.php @@ -21,7 +21,7 @@ class api_v3_EmailTest extends CiviUnitTestCase { protected $_entity; protected $_params; - public function setUp() { + public function setUp(): void { $this->_entity = 'Email'; parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/EntityBatchTest.php b/tests/phpunit/api/v3/EntityBatchTest.php index 9446092ee4..0ed0b96d63 100644 --- a/tests/phpunit/api/v3/EntityBatchTest.php +++ b/tests/phpunit/api/v3/EntityBatchTest.php @@ -23,7 +23,7 @@ class api_v3_EntityBatchTest extends CiviUnitTestCase { public $DBResetRequired = FALSE; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/EntityJoinTest.php b/tests/phpunit/api/v3/EntityJoinTest.php index add0099aaa..fbcbca262f 100644 --- a/tests/phpunit/api/v3/EntityJoinTest.php +++ b/tests/phpunit/api/v3/EntityJoinTest.php @@ -17,7 +17,7 @@ */ class api_v3_EntityJoinTest extends CiviUnitTestCase { - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); } diff --git a/tests/phpunit/api/v3/EntityTagACLTest.php b/tests/phpunit/api/v3/EntityTagACLTest.php index 7c88088b28..2227f3b749 100644 --- a/tests/phpunit/api/v3/EntityTagACLTest.php +++ b/tests/phpunit/api/v3/EntityTagACLTest.php @@ -45,7 +45,7 @@ class api_v3_EntityTagACLTest extends CiviUnitTestCase { /** * Set up permissions for test. */ - public function setUp() { + public function setUp(): void { $this->useTransaction(TRUE); parent::setUp(); $individualID = $this->individualCreate(); diff --git a/tests/phpunit/api/v3/EntityTagTest.php b/tests/phpunit/api/v3/EntityTagTest.php index 887b083495..b99ecdc7d9 100644 --- a/tests/phpunit/api/v3/EntityTagTest.php +++ b/tests/phpunit/api/v3/EntityTagTest.php @@ -45,7 +45,7 @@ class api_v3_EntityTagTest extends CiviUnitTestCase { * * @throws \CRM_Core_Exception */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/EventTest.php b/tests/phpunit/api/v3/EventTest.php index b52d3a693e..5684ebeb9a 100644 --- a/tests/phpunit/api/v3/EventTest.php +++ b/tests/phpunit/api/v3/EventTest.php @@ -18,7 +18,7 @@ class api_v3_EventTest extends CiviUnitTestCase { protected $_apiversion; protected $_entity; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->_apiversion = 3; $this->_entity = 'event'; diff --git a/tests/phpunit/api/v3/ExceptionTest.php b/tests/phpunit/api/v3/ExceptionTest.php index bf0fb4361e..1a5e38baf0 100644 --- a/tests/phpunit/api/v3/ExceptionTest.php +++ b/tests/phpunit/api/v3/ExceptionTest.php @@ -22,7 +22,7 @@ class api_v3_ExceptionTest extends CiviUnitTestCase { * * This method is called before a test is executed. */ - protected function setUp() { + protected function setUp(): void { $this->useTransaction(TRUE); parent::setUp(); } diff --git a/tests/phpunit/api/v3/ExtensionTest.php b/tests/phpunit/api/v3/ExtensionTest.php index 18b371ff29..b62d9d474e 100644 --- a/tests/phpunit/api/v3/ExtensionTest.php +++ b/tests/phpunit/api/v3/ExtensionTest.php @@ -22,7 +22,7 @@ */ class api_v3_ExtensionTest extends CiviUnitTestCase { - public function setUp() { + public function setUp(): void { $url = 'file://' . dirname(dirname(dirname(dirname(__FILE__)))) . '/mock/extension_browser_results'; Civi::settings()->set('ext_repo_url', $url); } diff --git a/tests/phpunit/api/v3/FinancialTypeACLTest.php b/tests/phpunit/api/v3/FinancialTypeACLTest.php index 8ed31ec8cf..38b6eb83d7 100644 --- a/tests/phpunit/api/v3/FinancialTypeACLTest.php +++ b/tests/phpunit/api/v3/FinancialTypeACLTest.php @@ -46,7 +46,7 @@ class api_v3_FinancialTypeACLTest extends CiviUnitTestCase { /** * Setup function. */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->_apiversion = 3; diff --git a/tests/phpunit/api/v3/GrantTest.php b/tests/phpunit/api/v3/GrantTest.php index 5415759a48..70d9a2fede 100644 --- a/tests/phpunit/api/v3/GrantTest.php +++ b/tests/phpunit/api/v3/GrantTest.php @@ -24,7 +24,7 @@ class api_v3_GrantTest extends CiviUnitTestCase { public $DBResetRequired = FALSE; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->ids['contact'][0] = $this->individualCreate(); $this->params = [ diff --git a/tests/phpunit/api/v3/GroupContactTest.php b/tests/phpunit/api/v3/GroupContactTest.php index aa10784540..44affa3756 100644 --- a/tests/phpunit/api/v3/GroupContactTest.php +++ b/tests/phpunit/api/v3/GroupContactTest.php @@ -34,7 +34,7 @@ class api_v3_GroupContactTest extends CiviUnitTestCase { * * @todo set up calls function that doesn't work @ the moment */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/GroupNestingTest.php b/tests/phpunit/api/v3/GroupNestingTest.php index 08c5f9fbbd..fd34ce92d1 100644 --- a/tests/phpunit/api/v3/GroupNestingTest.php +++ b/tests/phpunit/api/v3/GroupNestingTest.php @@ -22,7 +22,7 @@ class api_v3_GroupNestingTest extends CiviUnitTestCase { * * This method is called before a test is executed. */ - protected function setUp() { + protected function setUp(): void { parent::setUp(); $this->ids['Group'] = []; diff --git a/tests/phpunit/api/v3/GroupOrganizationTest.php b/tests/phpunit/api/v3/GroupOrganizationTest.php index 4ed4ed9f0c..aed10a7ea4 100644 --- a/tests/phpunit/api/v3/GroupOrganizationTest.php +++ b/tests/phpunit/api/v3/GroupOrganizationTest.php @@ -22,7 +22,7 @@ class api_v3_GroupOrganizationTest extends CiviUnitTestCase { * Sets up the fixture, for example, opens a network connection. * This method is called before a test is executed. */ - protected function setUp() { + protected function setUp(): void { $this->_apiversion = 3; parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/ImTest.php b/tests/phpunit/api/v3/ImTest.php index 1ddcefe008..6002841201 100644 --- a/tests/phpunit/api/v3/ImTest.php +++ b/tests/phpunit/api/v3/ImTest.php @@ -23,7 +23,7 @@ class api_v3_ImTest extends CiviUnitTestCase { public $DBResetRequired = FALSE; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); diff --git a/tests/phpunit/api/v3/JobProcessMailingTest.php b/tests/phpunit/api/v3/JobProcessMailingTest.php index 5fb1a37479..0c75c11767 100644 --- a/tests/phpunit/api/v3/JobProcessMailingTest.php +++ b/tests/phpunit/api/v3/JobProcessMailingTest.php @@ -40,7 +40,7 @@ class api_v3_JobProcessMailingTest extends CiviUnitTestCase { */ private $_mut; - public function setUp() { + public function setUp(): void { parent::setUp(); // DGW CRM_Mailing_BAO_MailingJob::$mailsProcessed = 0; diff --git a/tests/phpunit/api/v3/JobProcessMembershipTest.php b/tests/phpunit/api/v3/JobProcessMembershipTest.php index 1d172816c1..e35484282a 100644 --- a/tests/phpunit/api/v3/JobProcessMembershipTest.php +++ b/tests/phpunit/api/v3/JobProcessMembershipTest.php @@ -60,7 +60,7 @@ class api_v3_JobProcessMembershipTest extends CiviUnitTestCase { */ public $_tomorrow; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->loadReferenceDates(); $this->loadMembershipStatuses(); diff --git a/tests/phpunit/api/v3/JobTestCustomDataTest.php b/tests/phpunit/api/v3/JobTestCustomDataTest.php index 2a971eb634..fa972463f2 100644 --- a/tests/phpunit/api/v3/JobTestCustomDataTest.php +++ b/tests/phpunit/api/v3/JobTestCustomDataTest.php @@ -68,7 +68,7 @@ class api_v3_JobTestCustomDataTest extends CiviUnitTestCase { */ public $customGroupID = NULL; - public function setUp() { + public function setUp(): void { parent::setUp(); $customGroup = $this->customGroupCreate(); $this->customGroupID = $customGroup['id']; diff --git a/tests/phpunit/api/v3/LineItemTest.php b/tests/phpunit/api/v3/LineItemTest.php index 29b83485a7..7ff061a439 100644 --- a/tests/phpunit/api/v3/LineItemTest.php +++ b/tests/phpunit/api/v3/LineItemTest.php @@ -24,7 +24,7 @@ class api_v3_LineItemTest extends CiviUnitTestCase { * * @throws \CRM_Core_Exception */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(); $contributionParams = [ diff --git a/tests/phpunit/api/v3/LocBlockTest.php b/tests/phpunit/api/v3/LocBlockTest.php index 26d532dd60..c7751fed7a 100644 --- a/tests/phpunit/api/v3/LocBlockTest.php +++ b/tests/phpunit/api/v3/LocBlockTest.php @@ -23,7 +23,7 @@ class api_v3_LocBlockTest extends CiviUnitTestCase { /** * Set up. */ - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); } diff --git a/tests/phpunit/api/v3/LoggingTest.php b/tests/phpunit/api/v3/LoggingTest.php index 0e6867edbb..a25dbb863f 100644 --- a/tests/phpunit/api/v3/LoggingTest.php +++ b/tests/phpunit/api/v3/LoggingTest.php @@ -22,7 +22,7 @@ class api_v3_LoggingTest extends CiviUnitTestCase { * * This method is called before a test is executed. */ - protected function setUp() { + protected function setUp(): void { $this->ensureTempColIsCleanedUp(); parent::setUp(); } diff --git a/tests/phpunit/api/v3/MailSettingsTest.php b/tests/phpunit/api/v3/MailSettingsTest.php index c9d62b7a9c..534e24ce6b 100644 --- a/tests/phpunit/api/v3/MailSettingsTest.php +++ b/tests/phpunit/api/v3/MailSettingsTest.php @@ -24,7 +24,7 @@ class api_v3_MailSettingsTest extends CiviUnitTestCase { public $DBResetRequired = FALSE; - public function setUp() { + public function setUp(): void { $this->params = [ 'domain_id' => 1, 'name' => "my mail setting", diff --git a/tests/phpunit/api/v3/MailingABTest.php b/tests/phpunit/api/v3/MailingABTest.php index 39fc245793..d31d66fd5f 100644 --- a/tests/phpunit/api/v3/MailingABTest.php +++ b/tests/phpunit/api/v3/MailingABTest.php @@ -38,7 +38,7 @@ class api_v3_MailingABTest extends CiviUnitTestCase { protected $_entity = 'MailingAB'; protected $_groupID; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); $this->createLoggedInUser(); diff --git a/tests/phpunit/api/v3/MailingContactTest.php b/tests/phpunit/api/v3/MailingContactTest.php index 5d71833467..9fe67eb990 100644 --- a/tests/phpunit/api/v3/MailingContactTest.php +++ b/tests/phpunit/api/v3/MailingContactTest.php @@ -26,7 +26,7 @@ class api_v3_MailingContactTest extends CiviUnitTestCase { protected $_entity = 'mailing'; - public function setUp() { + public function setUp(): void { parent::setUp(); $params = [ 'first_name' => 'abc1', diff --git a/tests/phpunit/api/v3/MailingGroupTest.php b/tests/phpunit/api/v3/MailingGroupTest.php index e1b09ea923..27e78ffc21 100644 --- a/tests/phpunit/api/v3/MailingGroupTest.php +++ b/tests/phpunit/api/v3/MailingGroupTest.php @@ -20,7 +20,7 @@ class api_v3_MailingGroupTest extends CiviUnitTestCase { protected $_email; protected $_apiversion; - public function setUp() { + public function setUp(): void { parent::setUp(); $this->useTransaction(TRUE); $this->_apiversion = 3; -- 2.25.1