From 7eebfcb9aaa2295f92ca5eddfff355f94d7920fe Mon Sep 17 00:00:00 2001
From: Eileen McNaughton <eileen@fuzion.co.nz>
Date: Fri, 2 May 2014 15:47:39 -0700
Subject: [PATCH] CRM-14367 fix incorrect addition of separators before first
 string

---
 CRM/Contribute/Form/Task/PDFLetterCommon.php | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/CRM/Contribute/Form/Task/PDFLetterCommon.php b/CRM/Contribute/Form/Task/PDFLetterCommon.php
index a1913d4dac..e4afbf66b7 100644
--- a/CRM/Contribute/Form/Task/PDFLetterCommon.php
+++ b/CRM/Contribute/Form/Task/PDFLetterCommon.php
@@ -238,10 +238,8 @@ class CRM_Contribute_Form_Task_PDFLetterCommon extends CRM_Contact_Form_Task_PDF
    */
   static function combineContributions($existing, $contribution, $separator) {
     foreach ($contribution as $field => $value) {
-      if(!isset($existing[$field])) {
-        $existing[$field] = '';
-      }
-      $existing[$field] .= $separator . $value;
+      $existing[$field] = isset($existing[$field]) ? $existing[$field] . $separator : '';
+      $existing[$field]  .= $value;
     }
     return $existing;
   }
-- 
2.25.1