From 7dccc95519688c1993823c1789e136923d0038a2 Mon Sep 17 00:00:00 2001 From: Tim Otten Date: Mon, 16 Jan 2023 21:48:24 -0800 Subject: [PATCH] (NFC) Cleanup Gitlab references --- CRM/Contact/Form/Task/PDFTrait.php | 2 +- CRM/Core/BAO/Address.php | 2 +- CRM/Core/Form/Task/PDFLetterCommon.php | 2 +- CRM/Core/I18n.php | 2 +- CRM/Upgrade/Incremental/php/FiveForty.php | 2 +- CRM/Upgrade/Incremental/php/FiveThirtyFive.php | 6 +++--- CRM/Upgrade/Incremental/php/FiveThirtyFour.php | 8 ++++---- CRM/Upgrade/Incremental/php/FiveThirtySeven.php | 10 +++++----- CRM/Upgrade/Incremental/php/FiveThirtySix.php | 14 +++++++------- CRM/Upgrade/Incremental/sql/5.3.alpha1.mysql.tpl | 2 +- api/v3/Contact.php | 2 +- release-notes/5.10.0.md | 2 +- release-notes/5.16.0.md | 2 +- release-notes/5.56.0.md | 2 +- release-notes/5.9.0.md | 2 +- tests/phpunit/CRM/Activity/BAO/ActivityTest.php | 4 ++-- tests/phpunit/CRM/Core/BAO/AddressTest.php | 4 ++-- 17 files changed, 34 insertions(+), 34 deletions(-) diff --git a/CRM/Contact/Form/Task/PDFTrait.php b/CRM/Contact/Form/Task/PDFTrait.php index 0889902391..e19cdac942 100644 --- a/CRM/Contact/Form/Task/PDFTrait.php +++ b/CRM/Contact/Form/Task/PDFTrait.php @@ -67,7 +67,7 @@ trait CRM_Contact_Form_Task_PDFTrait { FALSE ); - // Added for core#2121, + // Added for dev/core#2121, // To support sending a custom pdf filename before downloading. $form->addElement('hidden', 'pdf_file_name'); diff --git a/CRM/Core/BAO/Address.php b/CRM/Core/BAO/Address.php index 5b114112fc..9c7d90ff28 100644 --- a/CRM/Core/BAO/Address.php +++ b/CRM/Core/BAO/Address.php @@ -1311,7 +1311,7 @@ SELECT is_primary, if ($providerExists) { $provider::format($params); } - // core#2379 - Limit geocode length to 14 characters to avoid validation error on save in UI. + // dev/core#2379 - Limit geocode length to 14 characters to avoid validation error on save in UI. foreach (['geo_code_1', 'geo_code_2'] as $geocode) { if ($params[$geocode] ?? FALSE) { // ensure that if the geocoding provider (Google, OSM etc) has returned the string 'null' because they can't geocode, ensure that contacts are not placed on null island 0,0 diff --git a/CRM/Core/Form/Task/PDFLetterCommon.php b/CRM/Core/Form/Task/PDFLetterCommon.php index e9d32eab6c..af2e9e3fc3 100644 --- a/CRM/Core/Form/Task/PDFLetterCommon.php +++ b/CRM/Core/Form/Task/PDFLetterCommon.php @@ -62,7 +62,7 @@ class CRM_Core_Form_Task_PDFLetterCommon { FALSE ); - // Added for core#2121, + // Added for dev/core#2121, // To support sending a custom pdf filename before downloading. $form->addElement('hidden', 'pdf_file_name'); diff --git a/CRM/Core/I18n.php b/CRM/Core/I18n.php index b1aa48974a..01e6aef7fe 100644 --- a/CRM/Core/I18n.php +++ b/CRM/Core/I18n.php @@ -180,7 +180,7 @@ class CRM_Core_I18n { if (!$all) { $optionValues = []; - // Use `getValues`, not `buildOptions` to bypass hook_civicrm_fieldOptions. See core#1132. + // Use `getValues`, not `buildOptions` to bypass hook_civicrm_fieldOptions. See dev/core#1132. CRM_Core_OptionValue::getValues(['name' => 'languages'], $optionValues, 'weight', TRUE); $all = array_column($optionValues, 'label', 'name'); diff --git a/CRM/Upgrade/Incremental/php/FiveForty.php b/CRM/Upgrade/Incremental/php/FiveForty.php index 047d87a9a0..a771b55a8f 100644 --- a/CRM/Upgrade/Incremental/php/FiveForty.php +++ b/CRM/Upgrade/Incremental/php/FiveForty.php @@ -17,7 +17,7 @@ class CRM_Upgrade_Incremental_php_FiveForty extends CRM_Upgrade_Incremental_Base public function upgrade_5_40_alpha1($rev) { $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev); $this->addTask('Add option list for group_used_for', 'addGroupOptionList'); - $this->addTask('core-issue#2486 - Add product_id foreign key to civicrm_contribution_product', 'addContributionProductFK'); + $this->addTask('dev/core#2486 - Add product_id foreign key to civicrm_contribution_product', 'addContributionProductFK'); $this->addTask('Add membership_num_terms column to civicrm_line_item', 'addColumn', 'civicrm_line_item', 'membership_num_terms', "int unsigned DEFAULT NULL COMMENT 'Number of terms for this membership (only supported in Order->Payment flow). If the field is NULL it means unknown and it will be assumed to be 1 during payment.create if entity_table is civicrm_membership'" ); diff --git a/CRM/Upgrade/Incremental/php/FiveThirtyFive.php b/CRM/Upgrade/Incremental/php/FiveThirtyFive.php index 7d3e3f3c5a..54ffd45a07 100644 --- a/CRM/Upgrade/Incremental/php/FiveThirtyFive.php +++ b/CRM/Upgrade/Incremental/php/FiveThirtyFive.php @@ -22,11 +22,11 @@ class CRM_Upgrade_Incremental_php_FiveThirtyFive extends CRM_Upgrade_Incremental public function upgrade_5_35_alpha1(string $rev): void { $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev); - $this->addTask('dev/core/#2329 - Add is_active to Country', 'addColumn', + $this->addTask('dev/core#2329 - Add is_active to Country', 'addColumn', 'civicrm_country', 'is_active', "tinyint DEFAULT 1 COMMENT 'Is this Country active?'"); - $this->addTask('dev/core/#2329 - Add is_active to StateProvince', 'addColumn', + $this->addTask('dev/core#2329 - Add is_active to StateProvince', 'addColumn', 'civicrm_state_province', 'is_active', "tinyint DEFAULT 1 COMMENT 'Is this StateProvince active?'"); - $this->addTask('dev/core/#2329 - Add is_active to County', 'addColumn', + $this->addTask('dev/core#2329 - Add is_active to County', 'addColumn', 'civicrm_county', 'is_active', "tinyint DEFAULT 1 COMMENT 'Is this County active?'"); } diff --git a/CRM/Upgrade/Incremental/php/FiveThirtyFour.php b/CRM/Upgrade/Incremental/php/FiveThirtyFour.php index 7c6c496876..00419821e0 100644 --- a/CRM/Upgrade/Incremental/php/FiveThirtyFour.php +++ b/CRM/Upgrade/Incremental/php/FiveThirtyFour.php @@ -122,16 +122,16 @@ class CRM_Upgrade_Incremental_php_FiveThirtyFour extends CRM_Upgrade_Incremental $this->addTask('Migrate SMTP password', 'migrateSmtpPasswords'); } - $this->addTask('core-issue#365 - Add created_date to civicrm_action_schedule', 'addColumn', + $this->addTask('dev/core#365 - Add created_date to civicrm_action_schedule', 'addColumn', 'civicrm_action_schedule', 'created_date', "timestamp NULL DEFAULT CURRENT_TIMESTAMP COMMENT 'When was the schedule reminder created.'"); - $this->addTask('core-issue#365 - Add modified_date to civicrm_action_schedule', 'addColumn', + $this->addTask('dev/core#365 - Add modified_date to civicrm_action_schedule', 'addColumn', 'civicrm_action_schedule', 'modified_date', "timestamp NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'When was the schedule reminder created.'"); - $this->addTask('core-issue#365 - Add effective_start_date to civicrm_action_schedule', 'addColumn', + $this->addTask('dev/core#365 - Add effective_start_date to civicrm_action_schedule', 'addColumn', 'civicrm_action_schedule', 'effective_start_date', "timestamp NULL COMMENT 'Earliest date to consider start events from.'"); - $this->addTask('core-issue#365 - Add effective_end_date to civicrm_action_schedule', 'addColumn', + $this->addTask('dev/core#365 - Add effective_end_date to civicrm_action_schedule', 'addColumn', 'civicrm_action_schedule', 'effective_end_date', "timestamp NULL COMMENT 'Latest date to consider end events from.'"); $this->addTask('Set defaults and required on financial type boolean fields', 'updateFinancialTypeTable'); diff --git a/CRM/Upgrade/Incremental/php/FiveThirtySeven.php b/CRM/Upgrade/Incremental/php/FiveThirtySeven.php index b773ab8a9f..7e5ad9ff53 100644 --- a/CRM/Upgrade/Incremental/php/FiveThirtySeven.php +++ b/CRM/Upgrade/Incremental/php/FiveThirtySeven.php @@ -43,13 +43,13 @@ class CRM_Upgrade_Incremental_php_FiveThirtySeven extends CRM_Upgrade_Incrementa */ public function upgrade_5_37_alpha1($rev) { $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev); - $this->addTask('core-issue#1845 - Alter Foreign key on civicrm_group to delete when the associated group when the saved search is deleted', 'alterSavedSearchFK'); - $this->addTask('core-issue#2243 - Add note_date to civicrm_note', 'addColumn', + $this->addTask('dev/core#1845 - Alter Foreign key on civicrm_group to delete when the associated group when the saved search is deleted', 'alterSavedSearchFK'); + $this->addTask('dev/core#2243 - Add note_date to civicrm_note', 'addColumn', 'civicrm_note', 'note_date', "timestamp NULL DEFAULT CURRENT_TIMESTAMP COMMENT 'Date attached to the note'"); - $this->addTask('core-issue#2243 - Add created_date to civicrm_note', 'addColumn', + $this->addTask('dev/core#2243 - Add created_date to civicrm_note', 'addColumn', 'civicrm_note', 'created_date', "timestamp NULL DEFAULT CURRENT_TIMESTAMP COMMENT 'When the note was created'"); - $this->addTask('core-issue#2243 - Update existing note_date and created_date', 'updateNoteDates'); - $this->addTask('core-issue#2487 Add / alter defaults for civicrm_contribution_recur', 'updateDBDefaultsForContributionRecur'); + $this->addTask('dev/core#2243 - Update existing note_date and created_date', 'updateNoteDates'); + $this->addTask('dev/core#2487 Add / alter defaults for civicrm_contribution_recur', 'updateDBDefaultsForContributionRecur'); $this->addTask('Install reCAPTCHA extension', 'installReCaptchaExtension'); } diff --git a/CRM/Upgrade/Incremental/php/FiveThirtySix.php b/CRM/Upgrade/Incremental/php/FiveThirtySix.php index 78ef2eb8c5..ba0ab2e70b 100644 --- a/CRM/Upgrade/Incremental/php/FiveThirtySix.php +++ b/CRM/Upgrade/Incremental/php/FiveThirtySix.php @@ -49,20 +49,20 @@ class CRM_Upgrade_Incremental_php_FiveThirtySix extends CRM_Upgrade_Incremental_ public function upgrade_5_36_alpha1(string $rev): void { // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev); - $this->addTask('core-issue#2422 - Add created_id to civicrm_saved_search', 'addColumn', + $this->addTask('dev/core#2422 - Add created_id to civicrm_saved_search', 'addColumn', 'civicrm_saved_search', 'created_id', "int(10) unsigned DEFAULT NULL COMMENT 'FK to contact table.'"); - $this->addTask('core-issue#2422 - Add modified_id to civicrm_saved_search', 'addColumn', + $this->addTask('dev/core#2422 - Add modified_id to civicrm_saved_search', 'addColumn', 'civicrm_saved_search', 'modified_id', "int(10) unsigned DEFAULT NULL COMMENT 'FK to contact table.'"); - $this->addTask('core-issue#2422 - Add expires_date to civicrm_saved_search', 'addColumn', + $this->addTask('dev/core#2422 - Add expires_date to civicrm_saved_search', 'addColumn', 'civicrm_saved_search', 'expires_date', "timestamp NULL DEFAULT NULL COMMENT 'Optional date after which the search is not needed'"); - $this->addTask('core-issue#2422 - Add created_date to civicrm_saved_search', 'addColumn', + $this->addTask('dev/core#2422 - Add created_date to civicrm_saved_search', 'addColumn', 'civicrm_saved_search', 'created_date', "timestamp NULL DEFAULT CURRENT_TIMESTAMP COMMENT 'When the search was created.'"); - $this->addTask('core-issue#2422 - Add modified_date to civicrm_saved_search', 'addColumn', + $this->addTask('dev/core#2422 - Add modified_date to civicrm_saved_search', 'addColumn', 'civicrm_saved_search', 'modified_date', "timestamp NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'When the search was last modified.'"); - $this->addTask('core-issue#2422 - Add description to civicrm_saved_search', 'addColumn', + $this->addTask('dev/core#2422 - Add description to civicrm_saved_search', 'addColumn', 'civicrm_saved_search', 'description', "text DEFAULT NULL"); - $this->addTask('core-issue#2422 - Add constraints to civicrm_saved_search', 'taskAddConstraints'); + $this->addTask('dev/core#2422 - Add constraints to civicrm_saved_search', 'taskAddConstraints'); } /** diff --git a/CRM/Upgrade/Incremental/sql/5.3.alpha1.mysql.tpl b/CRM/Upgrade/Incremental/sql/5.3.alpha1.mysql.tpl index 7c05f9ecaa..c99948dd6a 100644 --- a/CRM/Upgrade/Incremental/sql/5.3.alpha1.mysql.tpl +++ b/CRM/Upgrade/Incremental/sql/5.3.alpha1.mysql.tpl @@ -14,5 +14,5 @@ SET @UKCountryId = (SELECT id FROM civicrm_country cc WHERE cc.name = 'United Ki INSERT IGNORE INTO civicrm_state_province (country_id, abbreviation, name) VALUES (@UKCountryId, 'MON', 'Monmouthshire'); -{* dev/core/#152 *} +{* dev/core#152 *} UPDATE `civicrm_custom_field` set `html_type` = "Multi-Select" WHERE `html_type` = "AdvMulti-Select"; diff --git a/api/v3/Contact.php b/api/v3/Contact.php index 732f14be83..0fc2ca5b66 100644 --- a/api/v3/Contact.php +++ b/api/v3/Contact.php @@ -770,7 +770,7 @@ function civicrm_api3_contact_getquick($params) { if ($field_name == 'contact_id') { $field_name = 'id'; } - // core#1420 : trim non-numeric character from phone search string + // dev/core#1420 : trim non-numeric character from phone search string elseif ($field_name == 'phone_numeric') { $name = preg_replace('/[^\d]/', '', $name); } diff --git a/release-notes/5.10.0.md b/release-notes/5.10.0.md index e0fc05b648..4524bf189e 100644 --- a/release-notes/5.10.0.md +++ b/release-notes/5.10.0.md @@ -63,7 +63,7 @@ Released February 6, 2019 ### CiviCase -- **[dev-core#564](https://lab.civicrm.org/dev/core/issues/564) Differentiate +- **[dev/core#564](https://lab.civicrm.org/dev/core/issues/564) Differentiate case relationships in Contact Summary page ([13189](https://github.com/civicrm/civicrm-core/pull/13189))** diff --git a/release-notes/5.16.0.md b/release-notes/5.16.0.md index 82cddef0ff..39c010b676 100644 --- a/release-notes/5.16.0.md +++ b/release-notes/5.16.0.md @@ -363,7 +363,7 @@ Released August 7, 2019 [14625](https://github.com/civicrm/civicrm-core/pull/14625))** - **Improper character encoding breaks xml processor - ([dev-core#1079](https://lab.civicrm.org/dev/core/issues/1079): + ([dev/core#1079](https://lab.civicrm.org/dev/core/issues/1079): [14654](https://github.com/civicrm/civicrm-core/pull/14654))** - **Php 7.2 notices fix on import diff --git a/release-notes/5.56.0.md b/release-notes/5.56.0.md index 48a06ba5b4..f4e741e570 100644 --- a/release-notes/5.56.0.md +++ b/release-notes/5.56.0.md @@ -417,7 +417,7 @@ Released December 7, 2022 - **Additional Participants are incorrectly added to group set in profile for primary participant - ([dev/core/#3849](https://lab.civicrm.org/dev/core/-/issues/3849): + ([dev/core#3849](https://lab.civicrm.org/dev/core/-/issues/3849): [24633](https://github.com/civicrm/civicrm-core/pull/24633))** ### CiviMember diff --git a/release-notes/5.9.0.md b/release-notes/5.9.0.md index 687ecddb1f..e7c307dbc8 100644 --- a/release-notes/5.9.0.md +++ b/release-notes/5.9.0.md @@ -78,7 +78,7 @@ Released January 2, 2019 This change makes it so extension authors can specify phpType and crmType in their xml files. -- **[dev-core#565](https://lab.civicrm.org/dev/core/issues/565) Make subject +- **[dev/core#565](https://lab.civicrm.org/dev/core/issues/565) Make subject field of Note, inline editable in contact summary page ([13190](https://github.com/civicrm/civicrm-core/pull/13190))** diff --git a/tests/phpunit/CRM/Activity/BAO/ActivityTest.php b/tests/phpunit/CRM/Activity/BAO/ActivityTest.php index 14e6d8d8e5..d8a0dc4d6e 100644 --- a/tests/phpunit/CRM/Activity/BAO/ActivityTest.php +++ b/tests/phpunit/CRM/Activity/BAO/ActivityTest.php @@ -1440,7 +1440,7 @@ $text /** * Test that when a number is specified in the To Param of the SMS provider parameters that an SMS is sent - * @see dev/core/#273 + * @see dev/core#273 */ public function testSendSMSMobileInToProviderParam(): void { $sent = $this->createSendSmsTest(TRUE, 2, TRUE); @@ -1449,7 +1449,7 @@ $text /** * Test that when a numbe ris specified in the To Param of the SMS provider parameters that an SMS is sent - * @see dev/core/#273 + * @see dev/core#273 */ public function testSendSMSMobileInToProviderParamWithDoNotSMS(): void { $sent = $this->createSendSmsTest(FALSE, 2, TRUE, ['do_not_sms' => 1]); diff --git a/tests/phpunit/CRM/Core/BAO/AddressTest.php b/tests/phpunit/CRM/Core/BAO/AddressTest.php index 371440559e..e1c573bf8f 100644 --- a/tests/phpunit/CRM/Core/BAO/AddressTest.php +++ b/tests/phpunit/CRM/Core/BAO/AddressTest.php @@ -726,7 +726,7 @@ class CRM_Core_BAO_AddressTest extends CiviUnitTestCase { } /** - * dev/core#1670 - Ensure that the custom fields on adresses are copied + * dev/dev/core#1670 - Ensure that the custom fields on adresses are copied * to inherited address * 1. test the creation of the shared address with custom field * 2. test the update of the custom field in the master @@ -823,7 +823,7 @@ class CRM_Core_BAO_AddressTest extends CiviUnitTestCase { } /** - * Test core#2379 fix - geocodes shouldn't be > 14 characters. + * Test dev/core#2379 fix - geocodes shouldn't be > 14 characters. */ public function testLongGeocodes() { $contactId = $this->individualCreate(); -- 2.25.1