From 7d58c44af381f06528449d1ed9b46d39c0151bd8 Mon Sep 17 00:00:00 2001 From: eileen Date: Mon, 13 Nov 2017 20:57:49 +1300 Subject: [PATCH] NFC code tidy up, convert result to array more cleanly --- CRM/Price/BAO/LineItem.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CRM/Price/BAO/LineItem.php b/CRM/Price/BAO/LineItem.php index cd42977348..6a7209769c 100644 --- a/CRM/Price/BAO/LineItem.php +++ b/CRM/Price/BAO/LineItem.php @@ -829,12 +829,11 @@ WHERE li.contribution_id = %1"; GROUP BY li.entity_table, li.entity_id, price_field_value_id, fi.id "; $updateFinancialItemInfoDAO = CRM_Core_DAO::executeQuery($updateFinancialItem); + $financialItemResult = $updateFinancialItemInfoDAO->fetchAll(); $invoiceSettings = Civi::settings()->get('contribution_invoice_settings'); $taxTerm = CRM_Utils_Array::value('tax_term', $invoiceSettings); - $updateFinancialItemInfoValues = array(); - while ($updateFinancialItemInfoDAO->fetch()) { - $updateFinancialItemInfoValues = (array) $updateFinancialItemInfoDAO; + foreach ($financialItemResult as $updateFinancialItemInfoValues) { $updateFinancialItemInfoValues['transaction_date'] = date('YmdHis'); // the below params are not needed $previousFinancialItemID = $updateFinancialItemInfoValues['id']; -- 2.25.1