From 7b97a02960c75105e87f1d3f9711a3ccbf938596 Mon Sep 17 00:00:00 2001 From: eileen Date: Fri, 20 Dec 2019 11:14:38 +1300 Subject: [PATCH] dev/core#1482 Remove lines of code that appear to relate to legacy logic As discussed in https://lab.civicrm.org/dev/core/issues/1482 the subscription history table appears to still be used for recording group history but this business of creating a row with no attached group appears to be from a logic flow that is long-superceded by change log & db logging --- CRM/Contact/BAO/Contact.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/CRM/Contact/BAO/Contact.php b/CRM/Contact/BAO/Contact.php index 644b365683..54009a2bd3 100644 --- a/CRM/Contact/BAO/Contact.php +++ b/CRM/Contact/BAO/Contact.php @@ -393,16 +393,6 @@ class CRM_Contact_BAO_Contact extends CRM_Contact_DAO_Contact { CRM_Core_BAO_CustomValueTable::store($params['custom'], 'civicrm_contact', $contact->id); } - // make a civicrm_subscription_history entry only on contact create (CRM-777) - if (empty($params['contact_id'])) { - $subscriptionParams = [ - 'contact_id' => $contact->id, - 'status' => 'Added', - 'method' => 'Admin', - ]; - CRM_Contact_BAO_SubscriptionHistory::create($subscriptionParams); - } - $transaction->commit(); // CRM-6367: fetch the right label for contact type’s display -- 2.25.1