From 7a19c557956db0f5dc22d2cb94b582550bfb4bf5 Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Fri, 20 Mar 2020 11:54:49 -0400
Subject: [PATCH] Dashboard - serialize field in metadata

---
 CRM/Core/BAO/Dashboard.php    | 3 ---
 CRM/Core/DAO/Dashboard.php    | 3 ++-
 xml/schema/Core/Dashboard.xml | 1 +
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/CRM/Core/BAO/Dashboard.php b/CRM/Core/BAO/Dashboard.php
index b241a30b10..36ea12fcc1 100644
--- a/CRM/Core/BAO/Dashboard.php
+++ b/CRM/Core/BAO/Dashboard.php
@@ -423,9 +423,6 @@ class CRM_Core_BAO_Dashboard extends CRM_Core_DAO_Dashboard {
       $dashlet->id = $dashboardID;
     }
 
-    if (isset($params['permission']) && is_array($params['permission'])) {
-      $params['permission'] = implode(',', $params['permission']);
-    }
     $dashlet->copyValues($params);
     $dashlet->save();
 
diff --git a/CRM/Core/DAO/Dashboard.php b/CRM/Core/DAO/Dashboard.php
index 13fbdbf5d1..65facfb0fc 100644
--- a/CRM/Core/DAO/Dashboard.php
+++ b/CRM/Core/DAO/Dashboard.php
@@ -6,7 +6,7 @@
  *
  * Generated from xml/schema/CRM/Core/Dashboard.xml
  * DO NOT EDIT.  Generated by CRM_Core_CodeGen
- * (GenCodeChecksum:6b9dee0261c55c757550983c4fbd9aea)
+ * (GenCodeChecksum:06a6051f8aa495ae244afaa0e75aa7e0)
  */
 
 /**
@@ -214,6 +214,7 @@ class CRM_Core_DAO_Dashboard extends CRM_Core_DAO {
           'entity' => 'Dashboard',
           'bao' => 'CRM_Core_BAO_Dashboard',
           'localizable' => 0,
+          'serialize' => self::SERIALIZE_COMMA,
         ],
         'permission_operator' => [
           'name' => 'permission_operator',
diff --git a/xml/schema/Core/Dashboard.xml b/xml/schema/Core/Dashboard.xml
index 96da590e28..00500943a8 100644
--- a/xml/schema/Core/Dashboard.xml
+++ b/xml/schema/Core/Dashboard.xml
@@ -76,6 +76,7 @@
     <length>255</length>
     <comment>Permission for the dashlet</comment>
     <add>3.1</add>
+    <serialize>COMMA</serialize>
   </field>
   <field>
     <name>permission_operator</name>
-- 
2.25.1