From 79ba796ca945fb347e97098467c94c65b7d20349 Mon Sep 17 00:00:00 2001 From: Coleman Watts Date: Wed, 6 Apr 2022 09:49:57 -0400 Subject: [PATCH] Emit deprecated warning for typo version of hook_civicrm_links The context string 'create.new.shorcuts' was deprecated in 2018. This adds a noisy warning to ensure extension devs update their code. --- CRM/Core/Block.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/CRM/Core/Block.php b/CRM/Core/Block.php index cdde5b928e..845c9b59fc 100644 --- a/CRM/Core/Block.php +++ b/CRM/Core/Block.php @@ -394,9 +394,6 @@ class CRM_Core_Block { } $values = []; - foreach ($shortCuts as $key => $short) { - $values[$key] = self::setShortCutValues($short); - } // Deprecated hook with typo. Please don't use this! CRM_Utils_Hook::links('create.new.shorcuts', @@ -404,6 +401,13 @@ class CRM_Core_Block { CRM_Core_DAO::$_nullObject, $values ); + if ($values) { + CRM_Core_Error::deprecatedWarning('hook_civicrm_links "create.new.shorcuts" deprecated in favor of "create.new.shortcuts"'); + } + + foreach ($shortCuts as $key => $short) { + $values[$key] = self::setShortCutValues($short); + } // Hook that enables extensions to add user-defined links CRM_Utils_Hook::links('create.new.shortcuts', -- 2.25.1