From 6ffca0c20382af66c8845d93eb041c5ec3799470 Mon Sep 17 00:00:00 2001 From: Jay Pfaffman Date: Tue, 4 Aug 2020 15:47:30 -0700 Subject: [PATCH] FIX: discourse-doctor plugin check too loose (#478) The non-official plugin check was looking only for `git`, which would match other things in the yml file (e.g., a digital ocean S3 bucket name). `grep` for `'git clone'` should solve that problem. Though I did test this edit on a running sitee, I made these edit in the web interface by hand rather than pushing a commit where I tested it. Please look twice to make sure that I didn't do something silly when making the edit here. --- discourse-doctor | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/discourse-doctor b/discourse-doctor index 67c4739..4d66900 100755 --- a/discourse-doctor +++ b/discourse-doctor @@ -185,7 +185,7 @@ get_discourse_config() { check_plugins() { log -e "\n\n==================== PLUGINS ====================" - log -e "$(grep git containers/$app_name.yml)" + log -e "$(grep 'git clone' containers/$app_name.yml)" grep git containers/$app_name.yml > /tmp/$PPID.grep if grep -cv "github.com/discourse" /tmp/$PPID.grep > /dev/null -- 2.25.1