From 6b761cabe56fb6380710a43da4d2d371ade453c8 Mon Sep 17 00:00:00 2001
From: larssandergreen <lars@wildsight.ca>
Date: Tue, 23 May 2023 17:59:04 -0600
Subject: [PATCH] Clean up scheduled jobs

---
 CRM/Admin/Page/Job.php           | 12 ++++++------
 templates/CRM/Admin/Page/Job.tpl |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/CRM/Admin/Page/Job.php b/CRM/Admin/Page/Job.php
index 80ba5524ab..72d9d3eed8 100644
--- a/CRM/Admin/Page/Job.php
+++ b/CRM/Admin/Page/Job.php
@@ -52,18 +52,18 @@ class CRM_Admin_Page_Job extends CRM_Core_Page_Basic {
           'qs' => 'jid=%%id%%&reset=1',
           'title' => ts('See log entries for this Scheduled Job'),
         ],
+        CRM_Core_Action::VIEW => [
+          'name' => ts('Execute'),
+          'url' => 'civicrm/admin/job/edit',
+          'qs' => 'action=view&id=%%id%%&reset=1',
+          'title' => ts('Execute Scheduled Job Now'),
+        ],
         CRM_Core_Action::UPDATE => [
           'name' => ts('Edit'),
           'url' => 'civicrm/admin/job/edit',
           'qs' => 'action=update&id=%%id%%&reset=1',
           'title' => ts('Edit Scheduled Job'),
         ],
-        CRM_Core_Action::VIEW => [
-          'name' => ts('Execute Now'),
-          'url' => 'civicrm/admin/job/edit',
-          'qs' => 'action=view&id=%%id%%&reset=1',
-          'title' => ts('Execute Scheduled Job Now'),
-        ],
         CRM_Core_Action::DISABLE => [
           'name' => ts('Disable'),
           'ref' => 'crm-enable-disable',
diff --git a/templates/CRM/Admin/Page/Job.tpl b/templates/CRM/Admin/Page/Job.tpl
index 57d54e6692..0030cffa10 100644
--- a/templates/CRM/Admin/Page/Job.tpl
+++ b/templates/CRM/Admin/Page/Job.tpl
@@ -42,11 +42,11 @@
         {foreach from=$rows item=row}
         <tr id="job-{$row.id}" class="crm-entity {cycle values="odd-row,even-row"} {$row.class}{if NOT $row.is_active} disabled{/if}">
             <td class="crm-job-name"><strong><span data-field="name">{$row.name}</span></strong> ({$row.run_frequency})<br/>
-                {$row.description}<br />
+                {if array_key_exists('description', $row)}{$row.description}{/if}<br />
                 {ts}API Entity:{/ts} {$row.api_entity}<br/>
                 {ts}API Action:{/ts} <strong>{$row.api_action}</strong><br/>
             </td>
-            <td class="crm-job-name">{if $row.parameters eq null}<em>{ts}no parameters{/ts}</em>{else}<pre>{$row.parameters}</pre>{/if}</td>
+            <td class="crm-job-name">{if $row.parameters eq null}<em>{ts}no parameters{/ts}</em>{else}{$row.parameters|nl2br}{/if}</td>
             <td class="crm-job-name">{if $row.last_run eq null}never{else}{$row.last_run|crmDate:$config->dateformatDatetime}{/if}</td>
             <td id="row_{$row.id}_status" class="crm-job-is_active">{if $row.is_active eq 1} {ts}Yes{/ts} {else} {ts}No{/ts} {/if}</td>
           <td>{$row.action|smarty:nodefaults|replace:'xx':$row.id}</td>
-- 
2.25.1