From 6901eb180f7e973425b157cd184e03888ad30cf2 Mon Sep 17 00:00:00 2001 From: eileen Date: Fri, 26 Jul 2013 00:56:08 +1200 Subject: [PATCH] CRM-13072 upgrade MembershipStatusTest to pass post -getcount fixes --- tests/phpunit/api/v3/MembershipStatusTest.php | 124 +++--------------- 1 file changed, 19 insertions(+), 105 deletions(-) diff --git a/tests/phpunit/api/v3/MembershipStatusTest.php b/tests/phpunit/api/v3/MembershipStatusTest.php index d44b4bd104..2599bfa1a0 100644 --- a/tests/phpunit/api/v3/MembershipStatusTest.php +++ b/tests/phpunit/api/v3/MembershipStatusTest.php @@ -1,5 +1,4 @@ _apiversion = 3; $this->_contactID = $this->individualCreate(); $this->_membershipTypeID = $this->membershipTypeCreate($this->_contactID); $this->_membershipStatusID = $this->membershipStatusCreate('test status'); @@ -76,11 +74,10 @@ class api_v3_MembershipStatusTest extends CiviUnitTestCase { * Test civicrm_membership_status_get with empty params */ function testGetEmptyParams() { - $params = array('version' => 3); - $result = civicrm_api('membership_status', 'get', $params); + $result = $this->callAPISuccess('membership_status', 'get', array()); // It should be 8 statuses, 7 default from mysql_data // plus one test status added in setUp - $this->assertEquals(8, $result['count'], 'In line ' . __LINE__); + $this->assertEquals(8, $result['count']); } /** @@ -89,10 +86,8 @@ class api_v3_MembershipStatusTest extends CiviUnitTestCase { function testGet() { $params = array( 'name' => 'test status', - 'version' => $this->_apiversion, ); - $result = civicrm_api('membership_status', 'get', $params); - $this->documentMe($params, $result, __FUNCTION__, __FILE__); + $result = $this->callAPIAndDocument('membership_status', 'get', $params, __FUNCTION__, __FILE__); $this->assertEquals($result['values'][$this->_membershipStatusID]['name'], "test status", "In line " . __LINE__); } @@ -100,44 +95,20 @@ class api_v3_MembershipStatusTest extends CiviUnitTestCase { * Test civicrm_membership_status_get. Success expected. */ function testGetLimit() { - $params = array( - 'version' => $this->_apiversion, - ); - $result = civicrm_api('membership_status', 'getcount', $params); + $result = $this->callAPISuccess('membership_status', 'getcount', array()); $this->assertGreaterThan(1, $result, "Check more than one exists In line " . __LINE__); $params['option.limit'] = 1; - $result = civicrm_api('membership_status', 'getcount', $params); - $this->assertEquals(1, $result, "Check only 1 retrieved " . __LINE__); - } - - function testMembershipStatusesGet() { - $params = 'wrong type'; - $result = civicrm_api('membership_status', 'get', $params); - $this->assertEquals(1, $result['is_error'], - "In line " . __LINE__ - ); - } - - ///////////////// civicrm_membership_status_create methods - function testCreateWithEmptyParams() { - $params = array(); - $result = $this->callAPIFailure('membership_status', 'create', $params); - } - - function testCreateWithWrongParamsType() { - $params = 'a string'; - $result = $this->callAPIFailure('membership_status', 'create', $params); - $params = array('version' =>3, 'id' => 'string'); - $result = civicrm_api('membership_status', 'create', $params); + $result = $this->callAPISuccess('membership_status', 'get', $params); + $this->assertEquals(1, $result['count'], "Check only 1 retrieved"); } function testCreateDuplicateName() { - $params = array('version' =>3, 'name' => 'name'); - $result = civicrm_api('membership_status', 'create', $params); - $this->assertAPISuccess($result); - $result = civicrm_api('membership_status', 'create', $params); - $this->assertEquals('A membership status with this name already exists.', $result['error_message']); + $params = array('name' => 'name'); + $result = $this->callAPISuccess('membership_status', 'create', $params); + $result = $this->callAPIFailure('membership_status', 'create', $params, + 'A membership status with this name already exists.' + ); } function testCreateWithMissingRequired() { @@ -148,87 +119,30 @@ class api_v3_MembershipStatusTest extends CiviUnitTestCase { function testCreate() { $params = array( 'name' => 'test membership status', - 'version' => $this->_apiversion, ); - $result = civicrm_api('membership_status', 'create', $params); - $this->documentMe($params, $result, __FUNCTION__, __FILE__); + $result = $this->callAPIAndDocument('membership_status', 'create', $params, __FUNCTION__, __FILE__); - $this->assertAPISuccess($result); $this->assertNotNull($result['id']); $this->membershipStatusDelete($result['id']); } function testUpdate() { $params = array( - 'name' => 'test membership status', - 'version' => $this->_apiversion, - ); - $result = civicrm_api('membership_status', 'create', $params); + 'name' => 'test membership status', ); + $result = $this->callAPISuccess('membership_status', 'create', $params); $id = $result['id']; - $result = civicrm_api('membership_status', 'get', $params); + $result = $this->callAPISuccess('membership_status', 'get', $params); $this->assertEquals('test membership status', $result['values'][$id]['name']); $newParams = array( 'id' => $id, - 'name' => 'renamed', - 'version' => $this->_apiversion, - ); - $result = civicrm_api('membership_status', 'create', $newParams); - $result = civicrm_api('membership_status', 'get', array('version' => 3, 'id' => $id)); + 'name' => 'renamed', ); + $result = $this->callAPISuccess('membership_status', 'create', $newParams); + $result = $this->callAPISuccess('membership_status', 'get', array('id' => $id)); $this->assertEquals('renamed', $result['values'][$id]['name']); $this->membershipStatusDelete($result['id']); } - ///////////////// civicrm_membership_status_update methods - //removed as none actually tested functionality - all just tested same stuff - //generic tests test. - - - - ///////////////// civicrm_membership_status_calc methods - /*pending it being re-enabled - - - function testCalculateStatusWithNoMembershipID( ) - { - $calcParams = array( 'title' => 'Does not make sense' ); - - $result = civicrm_api3_membership_status_calc( $calcParams ); - $this->assertEquals( $result['is_error'], 1,"In line " . __LINE__ ); - } - - function testCalculateStatus( ) - { - - $join_date = new DateTime(); - $start_date = new DateTime(); - $end_date = new DateTime(); - $join_date->modify("-5 months"); - $start_date->modify("-5 months"); - $end_date->modify("+7 months"); - - $params = array( - 'contact_id' => $this->_contactID, - 'membership_type_id' => $this->_membershipTypeID, - 'membership_status_id' => $this->_membershipStatusID, - 'join_date' => $join_date->format('Y-m-d'), - 'start_date' => $start_date->format('Y-m-d'), - 'end_date' => $end_date->format('Y-m-d') ); - - $membershipID = $this->contactMembershipCreate( $params ); - $membershipStatusID = CRM_Core_DAO::getFieldValue('CRM_Member_DAO_Membership',$membershipID,'status_id'); - $calcParams = array( 'membership_id' => $membershipID ); - $result = _civicrm_api3_membership_status_calc( $calcParams ); - $this->assertEquals( $result['is_error'], 0 ); - $this->assertEquals( $membershipStatusID,$result['id'] ); - $this->assertNotNull( $result['id'] ); - - $this->membershipDelete( $membershipID ); - } -*/ - - - ///////////////// civicrm_membership_status_delete methods function testDeleteEmptyParams() { $params = array(); -- 2.25.1