From 6899e2cd18676326fab7daa3d14c741e4da9ca4b Mon Sep 17 00:00:00 2001
From: Alice Frumin <alice@aghstrategies.com>
Date: Thu, 15 Dec 2022 11:41:27 -0500
Subject: [PATCH] Action Type as variable

---
 .../Action/SearchDisplay/GetSearchTasks.php   | 35 +++++++------------
 1 file changed, 12 insertions(+), 23 deletions(-)

diff --git a/ext/search_kit/Civi/Api4/Action/SearchDisplay/GetSearchTasks.php b/ext/search_kit/Civi/Api4/Action/SearchDisplay/GetSearchTasks.php
index e5164cbc54..9879c9289b 100644
--- a/ext/search_kit/Civi/Api4/Action/SearchDisplay/GetSearchTasks.php
+++ b/ext/search_kit/Civi/Api4/Action/SearchDisplay/GetSearchTasks.php
@@ -139,29 +139,18 @@ class GetSearchTasks extends \Civi\Api4\Generic\AbstractAction {
           }
           $key = \CRM_Core_Key::get(\CRM_Utils_Array::first((array) $task['class']), TRUE);
 
-          //break out mailing labels for redirect instead of crmPopup
-          if ($id == CRM_Core_Task::LABEL_CONTACTS) {
-            $tasks[$entity['name']]['contact.' . $id] = [
-              'title' => $task['title'],
-              'icon' => $task['icon'] ?? 'fa-gear',
-              'redirect' => [
-                'path' => "'{$task['url']}'",
-                'query' => "{reset: 1}",
-                'data' => "{cids: ids.join(','), qfKey: '$key'}",
-              ],
-            ];
-          }
-          else {
-            $tasks[$entity['name']]['contact.' . $id] = [
-              'title' => $task['title'],
-              'icon' => $task['icon'] ?? 'fa-gear',
-              'crmPopup' => [
-                'path' => "'{$task['url']}'",
-                'query' => "{reset: 1}",
-                'data' => "{cids: ids.join(','), qfKey: '$key'}",
-              ],
-            ];
-          }
+          // Print Labels action does not support popups, open full-screen
+          $actionType = $id == \CRM_Core_Task::LABEL_CONTACTS ? 'redirect' : 'crmPopup';
+
+          $tasks[$entity['name']]['contact.' . $id] = [
+            'title' => $task['title'],
+            'icon' => $task['icon'] ?? 'fa-gear',
+            $actionType => [
+              'path' => "'{$task['url']}'",
+              'query' => "{reset: 1}",
+              'data' => "{cids: ids.join(','), qfKey: '$key'}",
+            ],
+          ];
         }
       }
       if (!$this->checkPermissions || \CRM_Core_Permission::check(['merge duplicate contacts', 'delete contacts'])) {
-- 
2.25.1