From 669c51d8f56f00985d0b974e59e6552559f4163a Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Sun, 24 Sep 2023 10:45:59 +1300 Subject: [PATCH] Stop passing unused parameter --- CRM/Contribute/Form/ContributionBase.php | 6 +----- CRM/Event/Form/Registration.php | 7 +------ 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/CRM/Contribute/Form/ContributionBase.php b/CRM/Contribute/Form/ContributionBase.php index ac9a967edb..95ff6b6a4d 100644 --- a/CRM/Contribute/Form/ContributionBase.php +++ b/CRM/Contribute/Form/ContributionBase.php @@ -543,13 +543,9 @@ class CRM_Contribute_Form_ContributionBase extends CRM_Core_Form { if ($priceSetId) { if ($form->_action & CRM_Core_Action::UPDATE) { $form->_values['line_items'] = CRM_Price_BAO_LineItem::getLineItems($form->_id, 'contribution'); - $required = FALSE; - } - else { - $required = TRUE; } - $priceSet = CRM_Price_BAO_PriceSet::getSetDetail($priceSetId, $required); + $priceSet = CRM_Price_BAO_PriceSet::getSetDetail($priceSetId); $form->_priceSet = $priceSet[$priceSetId] ?? NULL; $form->_values['fee'] = $form->_priceSet['fields'] ?? NULL; $form->set('priceSet', $form->_priceSet); diff --git a/CRM/Event/Form/Registration.php b/CRM/Event/Form/Registration.php index 84f61d77b5..640e9d5cec 100644 --- a/CRM/Event/Form/Registration.php +++ b/CRM/Event/Form/Registration.php @@ -594,13 +594,8 @@ class CRM_Event_Form_Registration extends CRM_Core_Form { else { $form->_values['line_items'] = CRM_Price_BAO_LineItem::getLineItems($form->_participantId, 'participant'); } - $required = FALSE; } - else { - $required = TRUE; - } - - $priceSet = CRM_Price_BAO_PriceSet::getSetDetail($priceSetId, $required, $doNotIncludeExpiredFields); + $priceSet = CRM_Price_BAO_PriceSet::getSetDetail($priceSetId, NULL, $doNotIncludeExpiredFields); $form->_priceSet = $priceSet[$priceSetId] ?? NULL; $form->_values['fee'] = $form->_priceSet['fields'] ?? NULL; -- 2.25.1