From 62e0c841d825b8fd63506b25b42170d28475399b Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Sat, 23 Oct 2021 17:43:59 +1300 Subject: [PATCH] [Ref] Make functions private to protect them As we move functions to this class making them private once they are unused outside the class makes it easier to clean them up --- CRM/Contribute/BAO/FinancialProcessor.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CRM/Contribute/BAO/FinancialProcessor.php b/CRM/Contribute/BAO/FinancialProcessor.php index e9c28ef83e..ef50f69dd6 100644 --- a/CRM/Contribute/BAO/FinancialProcessor.php +++ b/CRM/Contribute/BAO/FinancialProcessor.php @@ -67,7 +67,7 @@ class CRM_Contribute_BAO_FinancialProcessor { * * @return array */ - public static function createFinancialItemsForLine($params, $context, $fields, array $previousLineItems, array $inputParams, bool $isARefund, $trxnIds, $fieldId): array { + private static function createFinancialItemsForLine($params, $context, $fields, array $previousLineItems, array $inputParams, bool $isARefund, $trxnIds, $fieldId): array { foreach ($fields as $fieldValueId => $lineItemDetails) { $prevFinancialItem = CRM_Financial_BAO_FinancialItem::getPreviousFinancialItem($lineItemDetails['id']); $receiveDate = CRM_Utils_Date::isoToMysql($params['prevContribution']->receive_date); @@ -133,7 +133,7 @@ class CRM_Contribute_BAO_FinancialProcessor { * * @return int */ - public static function getMultiplier($contribution_status_id, $context) { + private static function getMultiplier($contribution_status_id, $context) { if ($context === 'changeFinancialType' || CRM_Contribute_BAO_Contribution::isContributionStatusNegative($contribution_status_id)) { return -1; } -- 2.25.1