From 5deb2f24d8fa0396ce49d44ec4690fa15ae1195c Mon Sep 17 00:00:00 2001 From: eileen Date: Tue, 15 Dec 2015 08:28:25 +1300 Subject: [PATCH] CRM-17691 add the campaign id to selector even though it ? is not used? Without this we get enotices on a basic search - but there is no evidenc the field is actually rendered:-( Change-Id: I0b57e1dcaf444ad54f3d1144542e13a55f162659 --- CRM/Contribute/BAO/Query.php | 2 ++ CRM/Contribute/Selector/Search.php | 2 ++ 2 files changed, 4 insertions(+) diff --git a/CRM/Contribute/BAO/Query.php b/CRM/Contribute/BAO/Query.php index 60547162ee..ffadad33e4 100644 --- a/CRM/Contribute/BAO/Query.php +++ b/CRM/Contribute/BAO/Query.php @@ -868,6 +868,8 @@ class CRM_Contribute_BAO_Query { 'is_pay_later' => 1, 'thankyou_date' => 1, 'total_amount' => 1, + // Without this value here we get an e-notice BUT the value does not appear to be rendered anywhere. + 'contribution_campaign_id' => 1, 'contribution_status_id' => 1, // @todo return this & fix query to do pseudoconstant thing. 'contribution_status' => 1, diff --git a/CRM/Contribute/Selector/Search.php b/CRM/Contribute/Selector/Search.php index 1560690147..fd1327706d 100644 --- a/CRM/Contribute/Selector/Search.php +++ b/CRM/Contribute/Selector/Search.php @@ -406,6 +406,8 @@ class CRM_Contribute_Selector_Search extends CRM_Core_Selector_Base implements C } //carry campaign on selectors. + // @todo - I can't find any evidence that 'carrying' the campaign on selectors actually + // results in it being displayed anywhere so why do we do this??? $row['campaign'] = CRM_Utils_Array::value($result->contribution_campaign_id, $allCampaigns); $row['campaign_id'] = $result->contribution_campaign_id; -- 2.25.1