From 5db3ea35069872d9a263df4bfacdd76ea68ee1c2 Mon Sep 17 00:00:00 2001
From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Wed, 23 Mar 2022 10:04:52 +1300
Subject: [PATCH] Fix notices on Task.tpl (grumpy mode)

The addition of group.id to this id dates back to
https://github.com/civicrm/civicrm-core/pull/3191

- a huge PR which attempted to block collisions on the data table id per
https://issues.civicrm.org/jira/browse/CRM-14636

However, I could find no evidence that 'group' would ever be assigned here
and as a rather large PR I suspect there was a bit of pattern replacement
beyond what was confirmed....

Removing 'group' means the selector becomes 'selectedRecords-' - which is
what it is in practice anyway since group is not assigned. This is possibly
accidentally unique anyway because of the trailing '-'
---
 templates/CRM/Contact/Form/Task.tpl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/templates/CRM/Contact/Form/Task.tpl b/templates/CRM/Contact/Form/Task.tpl
index 80cdb64ade..19b7a14934 100644
--- a/templates/CRM/Contact/Form/Task.tpl
+++ b/templates/CRM/Contact/Form/Task.tpl
@@ -12,7 +12,7 @@
 {if $isSelectedContacts}
 <div id="popupContainer">
   <div class="crm-block crm-form-block crm-search-form-block">
-    <table id="selectedRecords-{if !empty($group)}{$group.id}{/if}" class="display crm-copy-fields crm-sortable">
+    <table id="selectedRecords-" class="display crm-copy-fields crm-sortable">
       <thead>
       <tr class="columnheader">
         <th class="contact_details">{ts}Name{/ts}</th>
@@ -56,8 +56,8 @@
     });
 
     var count = 0; var columns = ''; var sortColumn = '';
-    $('#selectedRecords-{/literal}{$group.id}{literal} th').each(function() {
-      if ($(this).attr('class') == 'contact_details') {
+    $('#selectedRecords- th').each(function() {
+      if ($(this).attr('class') === 'contact_details') {
         sortColumn += '[' + count + ', "asc" ],';
         columns += '{"sClass": "contact_details"},';
       }
-- 
2.25.1