From 5bfb071eccd783e42cf0bb23c6c8e7cd57d05612 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Mon, 27 Oct 2014 15:43:19 +1300 Subject: [PATCH] CRM-15527 minor tidyup since = False is never returned --- CRM/Contribute/BAO/Contribution.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 116f948030..b5a1c6e59e 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -2069,7 +2069,6 @@ WHERE contribution_id = %1 "; } } - $loadObjectSuccess = TRUE; if ($paymentProcessorID) { $paymentProcessor = CRM_Financial_BAO_PaymentProcessor::getPayment($paymentProcessorID, $this->is_test ? 'test' : 'live' @@ -2078,11 +2077,10 @@ WHERE contribution_id = %1 "; $this->_relatedObjects['paymentProcessor'] = &$paymentProcessor; } elseif ($required) { - $loadObjectSuccess = FALSE; throw new Exception("Could not find payment processor for contribution record: " . $this->id); } - return $loadObjectSuccess; + return TRUE; } /* -- 2.25.1