From 5bc608d35d9c0b7ce82f76754cabd2da94805979 Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Tue, 9 Jul 2019 17:00:30 +1200
Subject: [PATCH] Remove unecessary pass-by-reference

---
 CRM/Core/BAO/Mapping.php                   |  2 +-
 tests/phpunit/CRM/Core/BAO/MappingTest.php | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 tests/phpunit/CRM/Core/BAO/MappingTest.php

diff --git a/CRM/Core/BAO/Mapping.php b/CRM/Core/BAO/Mapping.php
index 04fb71b043..6e44b09388 100644
--- a/CRM/Core/BAO/Mapping.php
+++ b/CRM/Core/BAO/Mapping.php
@@ -1208,7 +1208,7 @@ class CRM_Core_BAO_Mapping extends CRM_Core_DAO_Mapping {
    *
    * @return NULL
    */
-  public static function saveMappingFields(&$params, $mappingId) {
+  public static function saveMappingFields($params, $mappingId) {
     //delete mapping fields records for existing mapping
     $mappingFields = new CRM_Core_DAO_MappingField();
     $mappingFields->mapping_id = $mappingId;
diff --git a/tests/phpunit/CRM/Core/BAO/MappingTest.php b/tests/phpunit/CRM/Core/BAO/MappingTest.php
new file mode 100644
index 0000000000..8bc7a2b16d
--- /dev/null
+++ b/tests/phpunit/CRM/Core/BAO/MappingTest.php
@@ -0,0 +1,18 @@
+<?php
+
+/**
+ * Class CRM_Core_BAO_MappingTest.
+ *
+ * @group headless
+ */
+class CRM_Core_BAO_MappingTest extends CiviUnitTestCase {
+
+  /**
+   * Test calling saveMapping.
+   */
+  public function testSaveMappingFields() {
+    $mapping = $this->callAPISuccess('Mapping', 'create', ['name' => 'teest']);
+    CRM_Core_BAO_Mapping::saveMappingFields([], $mapping['id']);
+  }
+
+}
-- 
2.25.1