From 5b0908ffd6a3d7a7f43f1c00c05506725d34f49b Mon Sep 17 00:00:00 2001
From: larssandergreen <lars@wildsight.ca>
Date: Wed, 26 Apr 2023 15:35:59 -0600
Subject: [PATCH] Fix emails

---
 templates/CRM/Activity/Form/ActivityView.tpl | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/templates/CRM/Activity/Form/ActivityView.tpl b/templates/CRM/Activity/Form/ActivityView.tpl
index 81f4c6d989..db41ef0a78 100644
--- a/templates/CRM/Activity/Form/ActivityView.tpl
+++ b/templates/CRM/Activity/Form/ActivityView.tpl
@@ -20,7 +20,7 @@
                 <td class="label">{ts}With Contact{/ts}</td><td class="view-value">{$values.target_contact_value}</td>
            </tr>
        {/if}
-       {if array_key_exists('mailingId', $values)}
+       {if (array_key_exists('mailingId', $values) && $values.mailingId)}
            <tr>
                 <td class="label">{ts}With Contact{/ts}</td><td class="view-value"><a href="{$values.mailingId}" title="{ts}View Mailing Report{/ts}"><i class="crm-i fa-chevron-right" aria-hidden="true"></i>{ts}Mailing Report{/ts}</a></td>
            </tr>
@@ -43,7 +43,7 @@
         <tr>
             <td class="label">{ts}Date and Time{/ts}</td><td class="view-value">{$values.activity_date_time|crmDate }</td>
         </tr>
-        {if array_key_exists('mailingId', $values)}
+        {if (array_key_exists('mailingId', $values) && $values.mailingId)}
             <tr>
                 <td class="label nowrap">
                    # of opens
@@ -83,9 +83,7 @@
                               <td>
                                   {$mailingReport.mailing.body_text|mb_truncate:30|escape|nl2br}
                                   <br />
-                                  {if $values.mailingId}
                                     <strong><a class="crm-popup" href='{$textViewURL}'><i class="crm-i fa-chevron-right" aria-hidden="true"></i> {ts}View complete message{/ts}</a></strong>
-                                  {/if}
                               </td>
                           </tr>
                       {/if}
@@ -96,9 +94,7 @@
                               <td>
                                   {$mailingReport.mailing.body_html|mb_truncate:30|escape|nl2br}
                                   <br/>
-                                  {if $values.mailingId}
                                     <strong><a class="crm-popup" href='{$htmlViewURL}'><i class="crm-i fa-chevron-right" aria-hidden="true"></i> {ts}View complete message{/ts}</a></strong>
-                                  {/if}
                               </td>
                           </tr>
                       {/if}
-- 
2.25.1