From 5ab8fe4ae9c5afa45a3dac2886830e5cc4ea1efb Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Tue, 22 Aug 2017 10:22:34 +1200
Subject: [PATCH] NFC remove some unused vars, fix comment

---
 CRM/Contact/Form/Task.php | 5 +----
 CRM/Utils/String.php      | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/CRM/Contact/Form/Task.php b/CRM/Contact/Form/Task.php
index c27f8480f6..a4ff17ecd3 100644
--- a/CRM/Contact/Form/Task.php
+++ b/CRM/Contact/Form/Task.php
@@ -459,7 +459,6 @@ class CRM_Contact_Form_Task extends CRM_Core_Form {
     // If contact list has changed, households will probably be at the end of
     // the list. Sort it again by sort_name.
     if (implode(',', $this->_contactIds) != $relID) {
-      $contact_sort = array();
       $result = civicrm_api3('Contact', 'get', array(
         'return' => array('id'),
         'id' => array('IN' => $this->_contactIds),
@@ -484,7 +483,6 @@ class CRM_Contact_Form_Task extends CRM_Core_Form {
     $searchParams = $this->controller->exportValues();
     if ($searchParams['radio_ts'] == 'ts_sel') {
       // Create a static group.
-
       $randID = md5(time() . rand(1, 1000)); // groups require a unique name
       $grpTitle = "Hidden Group {$randID}";
       $grpID = CRM_Core_DAO::getFieldValue('CRM_Contact_DAO_Group', $grpTitle, 'id', 'title');
@@ -509,7 +507,7 @@ class CRM_Contact_Form_Task extends CRM_Core_Form {
           'title' => $newGroupTitle,
           'group_type' => array('2' => 1),
         );
-        $group = CRM_Contact_BAO_Group::create($groupParams);
+        CRM_Contact_BAO_Group::create($groupParams);
       }
 
       // note at this point its a static group
@@ -517,7 +515,6 @@ class CRM_Contact_Form_Task extends CRM_Core_Form {
     }
     else {
       // Create a smart group.
-
       $ssId = $this->get('ssID');
       $hiddenSmartParams = array(
         'group_type' => array('2' => 1),
diff --git a/CRM/Utils/String.php b/CRM/Utils/String.php
index 17aed7f626..be6ba732a9 100644
--- a/CRM/Utils/String.php
+++ b/CRM/Utils/String.php
@@ -47,7 +47,7 @@ class CRM_Utils_String {
   /**
    * Convert a display name into a potential variable name.
    *
-   * @param $title title of the string
+   * @param string $title title of the string
    * @param int $maxLength
    *
    * @return string
-- 
2.25.1