From 55c10ad9bc6083e59ce86c417f3bf5d387d9466c Mon Sep 17 00:00:00 2001 From: Seamus Lee Date: Fri, 13 Sep 2019 13:55:48 +1000 Subject: [PATCH] [NFC] Add in code comments about the column default issue with is_email_receipt in case anyone else comes across this --- CRM/Contribute/BAO/Contribution.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 33a350ef6a..bf3b53a599 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -4526,6 +4526,10 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac elseif ($recurContrib && $recurringContributionID) { //CRM-13273 - is_email_receipt setting on recurring contribution should take precedence over contribution page setting // but CRM-16124 if $input['is_email_receipt'] is set then that should not be overridden. + // dev/core#1245 this maybe not the desired effect because the default value for is_email_receipt is set to 0 rather than 1 in + // Instance that had the table added via an upgrade in 4.1 + // see also https://github.com/civicrm/civicrm-svn/commit/7f39befd60bc735408d7866b02b3ac7fff1d4eea#diff-9ad8e290180451a2d6eacbd3d1ca7966R354 + // https://lab.civicrm.org/dev/core/issues/1245 $values['is_email_receipt'] = $recurContrib->is_email_receipt; } -- 2.25.1