From 541dedcdccc27ae2271c09db88f2cba06410b8e3 Mon Sep 17 00:00:00 2001 From: jervfors Date: Wed, 28 Oct 2009 12:01:57 +0000 Subject: [PATCH] Turning som FIXMEs into one-liners. git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13867 7612ce4b-ef26-0410-bec9-ea0150e637f0 --- templates/default/read_menubar_buttons.tpl | 11 +---------- templates/default/read_menubar_nav.tpl | 11 +---------- templates/default_advanced/read_menubar_buttons.tpl | 10 +--------- templates/default_advanced/read_menubar_nav.tpl | 10 +--------- 4 files changed, 4 insertions(+), 38 deletions(-) diff --git a/templates/default/read_menubar_buttons.tpl b/templates/default/read_menubar_buttons.tpl index 7ea9a13a..d2e51f4f 100644 --- a/templates/default/read_menubar_buttons.tpl +++ b/templates/default/read_menubar_buttons.tpl @@ -62,16 +62,7 @@ /** extract template variables **/ extract($t); -/*FIXME: This is a place where Marc's idea for putting all the buttons and - links and other widgets into an array is sorely needed instead of - hard-coding everything. Whomever implements that, PLEASE, PLEASE - look at how the preview pane plugin code is used in this same template - file for the *default_advanced* set to change some links and buttons - and make sure your implementation can support it (tip: it may or may - not be OK to let a plugin do the modification of the widgets, since - a template set can turn on the needed plugin, but that might not be - the most clear way to solve said issue).*/ - +/*FIXME: This is a place where Marc's idea for putting all the buttons and links and other widgets into an array is sorely needed instead of hard-coding everything. Whomever implements that, PLEASE, PLEASE look at how the preview pane plugin code is used in this same template file for the *default_advanced* set to change some links and buttons and make sure your implementation can support it (tip: it may or may not be OK to let a plugin do the modification of the widgets, since a template set can turn on the needed plugin, but that might not be the most clear way to solve said issue).*/ /** Begin template **/ if ($nav_on_top) { diff --git a/templates/default/read_menubar_nav.tpl b/templates/default/read_menubar_nav.tpl index 80f5f98e..87d73f92 100644 --- a/templates/default/read_menubar_nav.tpl +++ b/templates/default/read_menubar_nav.tpl @@ -49,16 +49,7 @@ /** extract template variables **/ extract($t); -/*FIXME: This is a place where Marc's idea for putting all the buttons and - links and other widgets into an array is sorely needed instead of - hard-coding everything. Whomever implements that, PLEASE, PLEASE - look at how the preview pane plugin code is used in this same template - file for the *default_advanced* set to change some links and buttons - and make sure your implementation can support it (tip: it may or may - not be OK to let a plugin do the modification of the widgets, since - a template set can turn on the needed plugin, but that might not be - the most clear way to solve said issue).*/ - +/*FIXME: This is a place where Marc's idea for putting all the buttons and links and other widgets into an array is sorely needed instead of hard-coding everything. Whomever implements that, PLEASE, PLEASE look at how the preview pane plugin code is used in this same template file for the *default_advanced* set to change some links and buttons and make sure your implementation can support it (tip: it may or may not be OK to let a plugin do the modification of the widgets, since a template set can turn on the needed plugin, but that might not be the most clear way to solve said issue).*/ /** Begin template **/ diff --git a/templates/default_advanced/read_menubar_buttons.tpl b/templates/default_advanced/read_menubar_buttons.tpl index 68b1cba0..f8ab8b7d 100644 --- a/templates/default_advanced/read_menubar_buttons.tpl +++ b/templates/default_advanced/read_menubar_buttons.tpl @@ -63,15 +63,7 @@ extract($t); -/*FIXME: This is a place where Marc's idea for putting all the buttons and - links and other widgets into an array is sorely needed instead of - hard-coding everything. Whomever implements that, PLEASE, PLEASE - look at how the preview pane plugin code is used here to change - some links and buttons and make sure your implementation can support - it (tip: it may or may not be OK to let a plugin do the modification - of the widgets, since a template set can turn on the needed plugin, - but that might not be the most clear way to solve said issue).*/ - +/*FIXME: This is a place where Marc's idea for putting all the buttons and links and other widgets into an array is sorely needed instead of hard-coding everything. Whomever implements that, PLEASE, PLEASE look at how the preview pane plugin code is used here to change some links and buttons and make sure your implementation can support it (tip: it may or may not be OK to let a plugin do the modification of the widgets, since a template set can turn on the needed plugin, but that might not be the most clear way to solve said issue).*/ /** preview pane prep */ global $data_dir, $username, $base_uri; diff --git a/templates/default_advanced/read_menubar_nav.tpl b/templates/default_advanced/read_menubar_nav.tpl index 3ad5fb98..ca6a4267 100644 --- a/templates/default_advanced/read_menubar_nav.tpl +++ b/templates/default_advanced/read_menubar_nav.tpl @@ -50,15 +50,7 @@ extract($t); -/*FIXME: This is a place where Marc's idea for putting all the buttons and - links and other widgets into an array is sorely needed instead of - hard-coding everything. Whomever implements that, PLEASE, PLEASE - look at how the preview pane plugin code is used here to change - some links and buttons and make sure your implementation can support - it (tip: it may or may not be OK to let a plugin do the modification - of the widgets, since a template set can turn on the needed plugin, - but that might not be the most clear way to solve said issue).*/ - +/*FIXME: This is a place where Marc's idea for putting all the buttons and links and other widgets into an array is sorely needed instead of hard-coding everything. Whomever implements that, PLEASE, PLEASE look at how the preview pane plugin code is used here to change some links and buttons and make sure your implementation can support it (tip: it may or may not be OK to let a plugin do the modification of the widgets, since a template set can turn on the needed plugin, but that might not be the most clear way to solve said issue).*/ /** preview pane prep */ global $data_dir, $username, $base_uri; -- 2.25.1