From 53c53da089c5d4b5794f196760e6d916a60d3257 Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Fri, 14 Jan 2022 19:20:01 -0500
Subject: [PATCH] [test] - Add test coverage for adjusting custom group weights

---
 .../api/v4/Action/BasicCustomFieldTest.php    | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/tests/phpunit/api/v4/Action/BasicCustomFieldTest.php b/tests/phpunit/api/v4/Action/BasicCustomFieldTest.php
index 240ce3a943..4cc32bbcf0 100644
--- a/tests/phpunit/api/v4/Action/BasicCustomFieldTest.php
+++ b/tests/phpunit/api/v4/Action/BasicCustomFieldTest.php
@@ -426,8 +426,25 @@ class BasicCustomFieldTest extends BaseCustomValueTest {
       $this->assertEquals(['One' => 1, 'Two' => 2, 'Three' => 3, 'Four' => 4], $getValues($groupName));
     }
 
+    // Testing custom group weights
+
+    $originalControlGroupWeight = $customGroups['controlGroup']['weight'];
+    $originalExperimentalGroupWeight = $customGroups['experimentalGroup']['weight'];
+
     // Ensure default weights were set for custom groups
-    $this->assertEquals($customGroups['controlGroup']['weight'] + 1, $customGroups['experimentalGroup']['weight']);
+    $this->assertEquals($originalControlGroupWeight + 1, $originalExperimentalGroupWeight);
+    // Updating custom group weight
+    $newExperimentalGroupWeight = CustomGroup::update(FALSE)
+      ->addValue('id', $customGroups['experimentalGroup']['id'])
+      ->addValue('weight', $originalControlGroupWeight)
+      ->execute()->first()['weight'];
+    // The other group's weight should have auto-adjusted
+    $newControlGroupWeight = CustomGroup::get(FALSE)
+      ->addWhere('id', '=', $customGroups['controlGroup']['id'])
+      ->execute()->first()['weight'];
+    $this->assertEquals($newExperimentalGroupWeight + 1, $newControlGroupWeight);
+
+    // Testing custom field weights
 
     // Move third option to second position
     CustomField::update(FALSE)
-- 
2.25.1