From 5066e05b1bf7376d11ef84be51ca4355a7ec06e4 Mon Sep 17 00:00:00 2001 From: Sudha Bisht Date: Wed, 24 Jun 2015 18:08:21 +0530 Subject: [PATCH] Remove hardcode value --- CRM/Member/BAO/Membership.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CRM/Member/BAO/Membership.php b/CRM/Member/BAO/Membership.php index 18a142a8a2..ecce3a4a82 100644 --- a/CRM/Member/BAO/Membership.php +++ b/CRM/Member/BAO/Membership.php @@ -2305,7 +2305,8 @@ INNER JOIN civicrm_contact contact ON ( contact.id = membership.contact_id AND */ public static function createOrRenewMembership($membershipParams, $contactID, $customFieldsFormatted, $membershipID, $memType, $isTest, $numTerms, $membershipContribution, &$form) { if (!empty($membershipContribution)) { - $pending = ($membershipContribution->contribution_status_id == 2) ? TRUE : FALSE; + $pendingStatus = CRM_Core_OptionGroup::getValue('contribution_status', 'Pending', 'name'); + $pending = ($membershipContribution->contribution_status_id == $pendingStatus) ? TRUE : FALSE; } $membership = self::renewMembershipFormWrapper($contactID, $memType, $isTest, $form, NULL, -- 2.25.1