From 4f8ccea0ef54dee25c98b17df8f1333bb8d27ecc Mon Sep 17 00:00:00 2001
From: Eileen McNaughton <eileen@fuzion.co.nz>
Date: Sat, 3 May 2014 08:01:46 -0700
Subject: [PATCH] Test fixes & a few comments

---
 CRM/Case/PseudoConstant.php |  8 ++++++++
 api/v3/System.php           |  2 +-
 api/v3/SystemLog.php        | 12 ++++++++++++
 3 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/CRM/Case/PseudoConstant.php b/CRM/Case/PseudoConstant.php
index 7696629b9e..e79e099378 100644
--- a/CRM/Case/PseudoConstant.php
+++ b/CRM/Case/PseudoConstant.php
@@ -131,6 +131,9 @@ class CRM_Case_PseudoConstant extends CRM_Core_PseudoConstant {
    *
    * @access public
    *
+   * @param string $column
+   * @param bool $onlyActive
+   *
    * @return array - array reference of all case type
    * @static
    */
@@ -161,6 +164,9 @@ class CRM_Case_PseudoConstant extends CRM_Core_PseudoConstant {
    *
    * @access public
    *
+   * @param string $column
+   * @param bool $onlyActive
+   *
    * @return array - array reference of all Encounter Medium.
    * @static
    */
@@ -184,6 +190,8 @@ class CRM_Case_PseudoConstant extends CRM_Core_PseudoConstant {
    * @param boolean $indexName - true return activity name in array
    * key else activity id as array key.
    *
+   * @param bool $all
+   *
    * @access public
    * @static
    *
diff --git a/api/v3/System.php b/api/v3/System.php
index 3203f23547..79c66f2645 100644
--- a/api/v3/System.php
+++ b/api/v3/System.php
@@ -126,7 +126,7 @@ function civicrm_api3_system_log($params) {
  * Metadata for log function
  * @param $params
  */
-function _civicrm_api3_system_log_spec($params) {
+function _civicrm_api3_system_log_spec(&$params) {
   $params['level'] = array(
     'title' => 'Log Level',
     'description' => 'Log level as described in PSR3 (info, debug, warning etc)',
diff --git a/api/v3/SystemLog.php b/api/v3/SystemLog.php
index 90809ca386..3faebbaa4b 100644
--- a/api/v3/SystemLog.php
+++ b/api/v3/SystemLog.php
@@ -47,6 +47,9 @@ function civicrm_api3_system_log_delete($params) {
 }
 
 /**
+ * Create system log
+ * It's arguable whether this function should exist as it fits our crud pattern and adding it meets our SyntaxConformance test requirements
+ * but it just wraps system.log which is more consistent with the PSR3 implemented.
  * @param $params
  *
  * @return array
@@ -55,6 +58,15 @@ function civicrm_api3_system_log_create($params) {
   return civicrm_api3('system', 'log', $params);
 }
 
+/**
+ * @param $params
+ *
+ * @return array
+ */
+function _civicrm_api3_system_log_create_spec(&$params) {
+  return _civicrm_api3_system_log_spec($params);
+}
+
 /**
  * @param $params
  *
-- 
2.25.1