From 4dca4ad7d3924b9367ee162fb9be19a4b5beea32 Mon Sep 17 00:00:00 2001 From: Tim Otten Date: Thu, 31 Dec 2020 01:29:58 -0800 Subject: [PATCH] (REF) CiviReport TestCaseTest - Use "Invasive" helper It's shorter/prettier --- .../phpunit/CRM/Report/Form/TestCaseTest.php | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/tests/phpunit/CRM/Report/Form/TestCaseTest.php b/tests/phpunit/CRM/Report/Form/TestCaseTest.php index 124c092b6d..17c6a84379 100644 --- a/tests/phpunit/CRM/Report/Form/TestCaseTest.php +++ b/tests/phpunit/CRM/Report/Form/TestCaseTest.php @@ -11,6 +11,8 @@ require_once 'CiviTest/CiviReportTestCase.php'; +use Civi\Test\Invasive; + /** * Verify that the CiviReportTestCase provides a working set of * primitives for tests. Do this by running various scenarios @@ -174,25 +176,19 @@ class CRM_Report_Form_TestCaseTest extends CiviReportTestCase { * Test processReportMode() Function in Reports */ public function testOutputMode() { - $clazz = new ReflectionClass('CRM_Report_Form'); $reportForm = new CRM_Report_Form(); - $params = $clazz->getProperty('_params'); - $params->setAccessible(TRUE); - $outputMode = $clazz->getProperty('_outputMode'); - $outputMode->setAccessible(TRUE); - - $params->setValue($reportForm, ['groups' => 4]); + Invasive::set([$reportForm, '_params'], ['groups' => 4]); $reportForm->processReportMode(); - $this->assertEquals('group', $outputMode->getValue($reportForm)); + $this->assertEquals('group', Invasive::get([$reportForm, '_outputMode'])); - $params->setValue($reportForm, ['task' => 'copy']); + Invasive::set([$reportForm, '_params'], ['task' => 'copy']); $reportForm->processReportMode(); - $this->assertEquals('copy', $outputMode->getValue($reportForm)); + $this->assertEquals('copy', Invasive::get([$reportForm, '_outputMode'])); - $params->setValue($reportForm, ['task' => 'print']); + Invasive::set([$reportForm, '_params'], ['task' => 'print']); $reportForm->processReportMode(); - $this->assertEquals('print', $outputMode->getValue($reportForm)); + $this->assertEquals('print', Invasive::get([$reportForm, '_outputMode'])); } } -- 2.25.1