From 4ae8ee70deef33f20f0750e808ccdbb0697be924 Mon Sep 17 00:00:00 2001 From: Christian Wach Date: Fri, 19 Oct 2018 14:44:05 +0100 Subject: [PATCH] Fix malformed redirect URLs --- CRM/Core/QuickForm/Action/Jump.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CRM/Core/QuickForm/Action/Jump.php b/CRM/Core/QuickForm/Action/Jump.php index fa8e4db71f..20dc0d6f5a 100644 --- a/CRM/Core/QuickForm/Action/Jump.php +++ b/CRM/Core/QuickForm/Action/Jump.php @@ -74,6 +74,9 @@ class CRM_Core_QuickForm_Action_Jump extends CRM_Core_QuickForm_Action { } // generate the URL for the page 'display' event and redirect to it $action = $current->getAttribute('action'); + // prevent URLs that end in ? from causing redirects + $action = rtrim($action, '?'); + // FIXME: this should be passed through CRM_Utils_System::url() $url = $action . (FALSE === strpos($action, '?') ? '?' : '&') . $current->getButtonName('display') . '=true' . '&qfKey=' . $page->get('qfKey'); CRM_Utils_System::redirect($url); -- 2.25.1