From 4ab1a3a3d06470bcfb9538bf45d50f4c741fa511 Mon Sep 17 00:00:00 2001 From: eileen Date: Thu, 18 Jul 2013 17:34:33 +1200 Subject: [PATCH] CRM-13074 - Failure on CMS user deletes contribution --- CRM/Contribute/Form/Contribution/Confirm.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/CRM/Contribute/Form/Contribution/Confirm.php b/CRM/Contribute/Form/Contribution/Confirm.php index 997ad8ac23..1b82146091 100644 --- a/CRM/Contribute/Form/Contribution/Confirm.php +++ b/CRM/Contribute/Form/Contribution/Confirm.php @@ -1453,10 +1453,6 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr elseif (isset($params['cms_contactID'])) { $contactID = $params['cms_contactID']; } - CRM_Contribute_BAO_Contribution_Utils::createCMSUser($params, - $contactID, - 'email-' . $form->_bltID - ); //create contribution activity w/ individual and target //activity w/ organisation contact id when onbelf, CRM-4027 @@ -1472,6 +1468,12 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr } $transaction->commit(); + // CRM-13074 - create the CMSUser after the transaction is completed as it + // is not appropriate to delete a valid contribution if a user create problem occurs + CRM_Contribute_BAO_Contribution_Utils::createCMSUser($params, + $contactID, + 'email-' . $form->_bltID + ); return $contribution; } -- 2.25.1