From 47f49a22ad11071b94a599fe82c086d25f57006e Mon Sep 17 00:00:00 2001 From: mark burdett Date: Sun, 23 Dec 2018 20:47:06 -0800 Subject: [PATCH] optimize CRM_Utils_String::ellipsify() method --- CRM/Utils/String.php | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/CRM/Utils/String.php b/CRM/Utils/String.php index 3f6005dabf..fe4353b3a4 100644 --- a/CRM/Utils/String.php +++ b/CRM/Utils/String.php @@ -657,18 +657,10 @@ class CRM_Utils_String { * @return string */ public static function ellipsify($string, $maxLen) { - $len = mb_strlen($string, 'UTF-8'); - if ($len <= $maxLen) { + if (mb_strlen($string, 'UTF-8') <= $maxLen) { return $string; } - else { - $end = $maxLen - 3; - while (mb_strlen($string, 'UTF-8') > $maxLen - 3) { - $string = mb_substr($string, 0, $end, 'UTF-8'); - $end = $end - 1; - } - return $string . '...'; - } + return mb_substr($string, 0, $maxLen - 3, 'UTF-8') . '...'; } /** -- 2.25.1