From 470190342489998f158e030e1b498bf28306e7fa Mon Sep 17 00:00:00 2001 From: eileenmcnaugton Date: Thu, 16 May 2019 14:29:39 +1200 Subject: [PATCH] [REF] Minor code readability fix --- CRM/Dedupe/Merger.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CRM/Dedupe/Merger.php b/CRM/Dedupe/Merger.php index 6703e57a7c..9300971e04 100644 --- a/CRM/Dedupe/Merger.php +++ b/CRM/Dedupe/Merger.php @@ -1092,8 +1092,7 @@ INNER JOIN civicrm_membership membership2 ON membership1.membership_type_id = m // CRM-15681 don't display sub-types in UI continue; } - foreach (['main', 'other'] as $moniker) { - $contact = &$$moniker; + foreach (['main' => $main, 'other' => $other] as $moniker => $contact) { $value = CRM_Utils_Array::value($field, $contact); if (isset($specialValues[$moniker][$field]) && is_string($specialValues[$moniker][$field])) { $value = CRM_Core_DAO::VALUE_SEPARATOR . trim($specialValues[$moniker][$field], CRM_Core_DAO::VALUE_SEPARATOR) . CRM_Core_DAO::VALUE_SEPARATOR; -- 2.25.1