From 467636921e37caae152235b0801b128b52c823ca Mon Sep 17 00:00:00 2001 From: eileenmcnaugton Date: Mon, 10 Aug 2015 13:42:25 +1200 Subject: [PATCH] CRM-16692 follow up removal of unused variables --- CRM/Contribute/BAO/Contribution/Utils.php | 7 +------ CRM/Contribute/Form/Contribution/Confirm.php | 14 +++----------- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution/Utils.php b/CRM/Contribute/BAO/Contribution/Utils.php index c91a9c85d1..91d48abea3 100644 --- a/CRM/Contribute/BAO/Contribution/Utils.php +++ b/CRM/Contribute/BAO/Contribution/Utils.php @@ -46,10 +46,7 @@ class CRM_Contribute_BAO_Contribution_Utils { * @param int $contributionTypeId * Financial type id. * @param int|string $component component id - * @param array $fieldTypes - * Presumably relates to custom field types - used when building data for sendMail. * @param $isTest - * @param $isPayLater * * @throws CRM_Core_Exception * @throws Exception @@ -63,9 +60,7 @@ class CRM_Contribute_BAO_Contribution_Utils { $contactID, $contributionTypeId, $component = 'contribution', - $fieldTypes = NULL, - $isTest, - $isPayLater + $isTest ) { CRM_Core_Payment_Form::mapParams($form->_bltID, $form->_params, $paymentParams, TRUE); $lineItems = $form->_lineItem; diff --git a/CRM/Contribute/Form/Contribution/Confirm.php b/CRM/Contribute/Form/Contribution/Confirm.php index d0091c2230..0c3a943a44 100644 --- a/CRM/Contribute/Form/Contribution/Confirm.php +++ b/CRM/Contribute/Form/Contribution/Confirm.php @@ -1513,9 +1513,7 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr $contactID, $financialTypeID, 'membership', - array(), - $isTest, - $isPayLater + $isTest ); if (!empty($paymentResult['contribution'])) { @@ -2250,9 +2248,7 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr // all the payment processors expect the name and address to be in the // so we copy stuff over to first_name etc. $paymentParams = $this->_params; - $contributionTypeId = $this->_values['financial_type_id']; - $fieldTypes = array(); if (!empty($paymentParams['onbehalf']) && is_array($paymentParams['onbehalf']) ) { @@ -2261,17 +2257,13 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr $this->_params[$key] = $value; } } - $fieldTypes = array('Contact', 'Organization', 'Contribution'); } - $financialTypeID = $this->wrangleFinancialTypeID($contributionTypeId); $result = CRM_Contribute_BAO_Contribution_Utils::processConfirm($this, $paymentParams, $contactID, - $financialTypeID, + $this->wrangleFinancialTypeID($this->_values['financial_type_id']), 'contribution', - $fieldTypes, - ($this->_mode == 'test') ? 1 : 0, - $isPayLater + ($this->_mode == 'test') ? 1 : 0 ); if (!empty($result['is_payment_failure'])) { -- 2.25.1