From 45db313648a347ae872b7a634dba485d7f31926e Mon Sep 17 00:00:00 2001 From: colemanw Date: Fri, 10 Nov 2023 13:59:01 -0500 Subject: [PATCH] APIv4 - Fix missing tag filer on Individual,Organization,Household entities --- .../Api4/Service/Spec/Provider/EntityTagFilterSpecProvider.php | 3 +++ tests/phpunit/api/v4/Entity/TagTest.php | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Civi/Api4/Service/Spec/Provider/EntityTagFilterSpecProvider.php b/Civi/Api4/Service/Spec/Provider/EntityTagFilterSpecProvider.php index bdc05f6810..1479819acf 100644 --- a/Civi/Api4/Service/Spec/Provider/EntityTagFilterSpecProvider.php +++ b/Civi/Api4/Service/Spec/Provider/EntityTagFilterSpecProvider.php @@ -53,6 +53,9 @@ class EntityTagFilterSpecProvider extends \Civi\Core\Service\AutoService impleme if ($action !== 'get') { return FALSE; } + if (CoreUtil::isContact($entity)) { + return TRUE; + } $usedFor = \CRM_Core_OptionGroup::values('tag_used_for', FALSE, FALSE, FALSE, NULL, 'name'); return in_array($entity, $usedFor, TRUE); } diff --git a/tests/phpunit/api/v4/Entity/TagTest.php b/tests/phpunit/api/v4/Entity/TagTest.php index 023d9c3322..379789caf9 100644 --- a/tests/phpunit/api/v4/Entity/TagTest.php +++ b/tests/phpunit/api/v4/Entity/TagTest.php @@ -21,6 +21,7 @@ namespace api\v4\Entity; use Civi\Api4\Contact; use api\v4\Api4TestBase; use Civi\Api4\EntityTag; +use Civi\Api4\Individual; use Civi\Api4\Tag; use Civi\Test\TransactionalInterface; @@ -79,7 +80,7 @@ class TagTest extends Api4TestBase implements TransactionalInterface { $this->assertCount(1, $shouldReturnContact1); $this->assertEquals($contact1['id'], $shouldReturnContact1->first()['id']); - $shouldReturnContact2 = Contact::get(FALSE) + $shouldReturnContact2 = Individual::get(FALSE) ->addSelect('id') ->addWhere('tags', 'IN', [$setChild['id']]) ->execute(); -- 2.25.1