From 455cd95dd8f61621fef0292e02a640bd115543e1 Mon Sep 17 00:00:00 2001 From: Mathieu Lutfy Date: Thu, 29 Aug 2019 14:12:55 -0400 Subject: [PATCH] Fix PayPalImpl Contribution Status PseudoConstant for non-English (use name, not label) --- CRM/Core/Payment/PayPalImpl.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/CRM/Core/Payment/PayPalImpl.php b/CRM/Core/Payment/PayPalImpl.php index 5b4a109802..905e369a61 100644 --- a/CRM/Core/Payment/PayPalImpl.php +++ b/CRM/Core/Payment/PayPalImpl.php @@ -352,7 +352,6 @@ class CRM_Core_Payment_PayPalImpl extends CRM_Core_Payment { * @throws \Civi\Payment\Exception\PaymentProcessorException */ public function doExpressCheckout(&$params) { - $statuses = CRM_Contribute_BAO_Contribution::buildOptions('contribution_status_id'); if (!empty($params['is_recur'])) { return $this->createRecurringPayments($params); } @@ -379,7 +378,6 @@ class CRM_Core_Payment_PayPalImpl extends CRM_Core_Payment { } /* Success */ - $params['trxn_id'] = $result['transactionid']; $params['gross_amount'] = $result['amt']; $params['fee_amount'] = $result['feeamt']; @@ -391,10 +389,10 @@ class CRM_Core_Payment_PayPalImpl extends CRM_Core_Payment { $params['pending_reason'] = $result['pendingreason']; if (!empty($params['is_recur'])) { // See comment block. - $params['payment_status_id'] = array_search('Pending', $statuses); + $params['payment_status_id'] = CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'contribution_status_id', 'Pending'); } else { - $params['payment_status_id'] = array_search('Completed', $statuses); + $params['payment_status_id'] = CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'contribution_status_id', 'Completed'); } return $params; } -- 2.25.1