From 423e3da6eb89c7aedf0040fc64269de17ea2e1a2 Mon Sep 17 00:00:00 2001 From: eileen Date: Sun, 14 Jul 2019 13:20:24 +1200 Subject: [PATCH] Stop passing export params to the merge function We have a string which does or doesn't have merge tokens in it - we don't need to determine this --- CRM/Export/BAO/ExportProcessor.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CRM/Export/BAO/ExportProcessor.php b/CRM/Export/BAO/ExportProcessor.php index bb0f470490..9dce29080a 100644 --- a/CRM/Export/BAO/ExportProcessor.php +++ b/CRM/Export/BAO/ExportProcessor.php @@ -1851,11 +1851,10 @@ class CRM_Export_BAO_ExportProcessor { /** * @param int $contactId - * @param array $exportParams * * @return array */ - public function replaceMergeTokens($contactId, $exportParams) { + public function replaceMergeTokens($contactId) { $greetings = []; $contact = NULL; @@ -1864,7 +1863,8 @@ class CRM_Export_BAO_ExportProcessor { 'addressee' => $this->getAddresseeGreetingTemplate(), ]; foreach ($greetingFields as $greeting => $greetingLabel) { - if (!empty($exportParams[$greeting])) { + $tokens = CRM_Utils_Token::getTokens($greetingLabel); + if (!empty($tokens)) { if (empty($contact)) { $values = [ 'id' => $contactId, @@ -1911,7 +1911,7 @@ class CRM_Export_BAO_ExportProcessor { if (!$sharedAddress) { if (!isset($this->contactGreetingFields[$dao->master_contact_id])) { - $this->contactGreetingFields[$dao->master_contact_id] = $this->replaceMergeTokens($dao->master_contact_id, $exportParams); + $this->contactGreetingFields[$dao->master_contact_id] = $this->replaceMergeTokens($dao->master_contact_id); } $masterPostalGreeting = CRM_Utils_Array::value('postal_greeting', $this->contactGreetingFields[$dao->master_contact_id], $dao->master_postal_greeting @@ -1921,7 +1921,7 @@ class CRM_Export_BAO_ExportProcessor { ); if (!isset($contactGreetingTokens[$dao->copy_contact_id])) { - $this->contactGreetingFields[$dao->copy_contact_id] = $this->replaceMergeTokens($dao->copy_contact_id, $exportParams); + $this->contactGreetingFields[$dao->copy_contact_id] = $this->replaceMergeTokens($dao->copy_contact_id); } $copyPostalGreeting = CRM_Utils_Array::value('postal_greeting', $this->contactGreetingFields[$dao->copy_contact_id], $dao->copy_postal_greeting -- 2.25.1