From 3fcd84887e8aefdaf910f707b33b1e8ed8b380ee Mon Sep 17 00:00:00 2001
From: Tim Otten <totten@civicrm.org>
Date: Wed, 10 May 2023 19:05:10 -0700
Subject: [PATCH] (NFC) Emphasize abbreviation "ESM"

---
 CRM/Core/Region.php                             | 2 ++
 CRM/Core/Resources/CollectionAdderInterface.php | 6 +++---
 CRM/Core/Resources/CollectionInterface.php      | 2 +-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/CRM/Core/Region.php b/CRM/Core/Region.php
index 08338cc426..b18cce15db 100644
--- a/CRM/Core/Region.php
+++ b/CRM/Core/Region.php
@@ -88,6 +88,7 @@ class CRM_Core_Region implements CRM_Core_Resources_CollectionInterface, CRM_Cor
           break;
 
         case 'scriptUrl':
+          // ECMAScript Modules (ESMs) are basically Javascript files, but they require a slightly different incantation.
           if (!empty($snippet['esm'])) {
             $html .= sprintf("<script type=\"module\" src=\"%s\">\n</script>\n", $snippet['scriptUrl']);
           }
@@ -110,6 +111,7 @@ class CRM_Core_Region implements CRM_Core_Resources_CollectionInterface, CRM_Cor
           break;
 
         case 'script':
+          // ECMAScript Modules (ESMs) are basically Javascript files, but they require a slightly different incantation.
           if (!empty($snippet['esm'])) {
             $html .= sprintf("<script type=\"module\">\n%s\n</script>\n", $snippet['script']);
           }
diff --git a/CRM/Core/Resources/CollectionAdderInterface.php b/CRM/Core/Resources/CollectionAdderInterface.php
index 606af6798e..14132522d3 100644
--- a/CRM/Core/Resources/CollectionAdderInterface.php
+++ b/CRM/Core/Resources/CollectionAdderInterface.php
@@ -45,7 +45,7 @@ interface CRM_Core_Resources_CollectionAdderInterface {
   public function addMarkup(string $markup, ...$options);
 
   /**
-   * Add an ECMAScript module to the current page (<SCRIPT TYPE=MODULE>).
+   * Add an ECMAScript Module (ESM) to the current page (<SCRIPT TYPE=MODULE>).
    *
    * Ex: addScript('alert("Hello world");', ['weight' => 123]);
    *
@@ -60,7 +60,7 @@ interface CRM_Core_Resources_CollectionAdderInterface {
   public function addModule(string $code, ...$options);
 
   /**
-   * Add an ECMAScript Module from file to the current page (<SCRIPT TYPE=MODULE SRC=...>).
+   * Add an ECMAScript Module (ESM) from file to the current page (<SCRIPT TYPE=MODULE SRC=...>).
    *
    * Ex: addScriptFile('myextension', 'myscript.js', ['weight' => 123]);
    *
@@ -77,7 +77,7 @@ interface CRM_Core_Resources_CollectionAdderInterface {
   public function addModuleFile(string $ext, string $file, ...$options);
 
   /**
-   * Add an ECMAScript Module by URL to the current page (<SCRIPT TYPE=MODULE SRC=...>).
+   * Add an ECMAScript Module (ESM) by URL to the current page (<SCRIPT TYPE=MODULE SRC=...>).
    *
    * Ex: addScriptUrl('http://example.com/foo.js', ['weight' => 123])
    *
diff --git a/CRM/Core/Resources/CollectionInterface.php b/CRM/Core/Resources/CollectionInterface.php
index 50a7aae347..531cb3949e 100644
--- a/CRM/Core/Resources/CollectionInterface.php
+++ b/CRM/Core/Resources/CollectionInterface.php
@@ -57,7 +57,7 @@
  *     not guaranteed among versions/implementations.)
  *   - disabled: int, default=0
  *   - region: string
- *   - esm: bool; for "script","scriptFile","scriptUrl", the "esm" flag enables Ecmascript 5 Module support
+ *   - esm: bool, enable ECMAScript Module (ESM) support for "script","scriptFile","scriptUrl"
  *   - translate: bool|string, Autoload translations. (Only applies to 'scriptFile')
  *       - FALSE: Do not load translated strings.
  *       - TRUE: Load translated strings. Use the $ext's default domain.
-- 
2.25.1