From 3f8fccc661b9bf26d4840f652705ad88e1d5c461 Mon Sep 17 00:00:00 2001 From: Christian Wach Date: Thu, 29 Nov 2018 11:23:43 +0000 Subject: [PATCH] Prevent viewport jump when toggling help on "Administer CiviCRM" screen --- CRM/Core/ShowHideBlocks.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CRM/Core/ShowHideBlocks.php b/CRM/Core/ShowHideBlocks.php index 510cdd8f54..8a09a36494 100644 --- a/CRM/Core/ShowHideBlocks.php +++ b/CRM/Core/ShowHideBlocks.php @@ -178,8 +178,8 @@ class CRM_Core_ShowHideBlocks { * @return array */ public static function links(&$form, $prefix, $showLinkText, $hideLinkText, $assign = TRUE) { - $showCode = "cj('#id_{$prefix}').show(); cj('#id_{$prefix}_show').hide();"; - $hideCode = "cj('#id_{$prefix}').hide(); cj('#id_{$prefix}_show').show(); return false;"; + $showCode = "if(event.preventDefault) event.preventDefault(); else event.returnValue = false; cj('#id_{$prefix}').show(); cj('#id_{$prefix}_show').hide();"; + $hideCode = "if(event.preventDefault) event.preventDefault(); else event.returnValue = false; cj('#id_{$prefix}').hide(); cj('#id_{$prefix}_show').show();"; self::setIcons(); $values = array(); -- 2.25.1