From 3bd63a4be5723094304407d8df85109730637373 Mon Sep 17 00:00:00 2001 From: Matthew Wire Date: Thu, 1 Feb 2018 21:24:58 +0700 Subject: [PATCH] Add commenting to explain +1/-1 days for membership dates calc --- CRM/Member/BAO/MembershipType.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CRM/Member/BAO/MembershipType.php b/CRM/Member/BAO/MembershipType.php index 0b141d8ac9..f6fb3d8c7d 100644 --- a/CRM/Member/BAO/MembershipType.php +++ b/CRM/Member/BAO/MembershipType.php @@ -536,6 +536,8 @@ class CRM_Member_BAO_MembershipType extends CRM_Member_DAO_MembershipType { $date = $membershipDetails->end_date; } $date = explode('-', $date); + // We have to add 1 day first in case it's the end of the month, then subtract afterwards + // eg. 2018-02-28 should renew to 2018-03-31, if we just added 1 month we'd get 2018-03-28 $logStartDate = date('Y-m-d', mktime(0, 0, 0, (double) $date[1], (double) ($date[2] + 1), -- 2.25.1