From 38a91fbed1ef754b271cad81e47d3521f8f3cf28 Mon Sep 17 00:00:00 2001
From: Jamie McClelland <jm@mayfirst.org>
Date: Mon, 5 Jun 2023 12:50:57 -0400
Subject: [PATCH] present friendlier error message if petition cannot be
 displayed.

---
 CRM/Campaign/Form/Petition/Signature.php      |  5 +-
 .../CRM/Campaign/Form/Petition/Signature.tpl  | 57 ++++++++++---------
 2 files changed, 34 insertions(+), 28 deletions(-)

diff --git a/CRM/Campaign/Form/Petition/Signature.php b/CRM/Campaign/Form/Petition/Signature.php
index 965f72d6f5..2c13088366 100644
--- a/CRM/Campaign/Form/Petition/Signature.php
+++ b/CRM/Campaign/Form/Petition/Signature.php
@@ -193,7 +193,10 @@ class CRM_Campaign_Form_Petition_Signature extends CRM_Core_Form {
       CRM_Core_Error::statusBounce(ts('Petition doesn\'t exist.'));
     }
     if ($this->petition['is_active'] == 0) {
-      CRM_Core_Error::statusBounce(ts('Petition is no longer active.'));
+      $this->assign('isActive', FALSE);
+    }
+    else {
+      $this->assign('isActive', TRUE);
     }
 
     //get userID from session
diff --git a/templates/CRM/Campaign/Form/Petition/Signature.tpl b/templates/CRM/Campaign/Form/Petition/Signature.tpl
index f34c436767..452c1cd311 100644
--- a/templates/CRM/Campaign/Form/Petition/Signature.tpl
+++ b/templates/CRM/Campaign/Form/Petition/Signature.tpl
@@ -21,34 +21,37 @@
   <div class='clear'></div>
 {/if}
 
-<div id="intro" class="crm-section">{$petition.instructions}</div>
-<div class="crm-block crm-petition-form-block">
-
-{if $duplicate == "confirmed"}
-  <p>
-  {ts}You have already signed this petition.{/ts}
-  </p>
-{/if}
-{if $duplicate == "unconfirmed"}
-  <p>{ts}You have already signed this petition but you still <b>need to verify your email address</b>.{/ts}<br/> {ts}Please check your email inbox for the confirmation email. If you don't find it, verify if it isn't in your spam folder.{/ts}</p>
-{/if}
-{if $duplicate}
-  <p>{ts}Thank you for your support.{/ts}</p>
-  {if $is_share}
-    {include file="CRM/Campaign/Page/Petition/SocialNetwork.tpl" petition_id=$survey_id petitionTitle=$petitionTitle}
-  {/if}
+{if ! $isActive}
+  <p>{ts}This petition is no longer active.{/ts}</p>
 {else}
-  <div class="crm-section crm-petition-contact-profile">
-    {include file="CRM/UF/Form/Block.tpl" fields=$petitionContactProfile hideFieldset=true}
-  </div>
-
-  <div class="crm-section crm-petition-activity-profile">
-    {include file="CRM/UF/Form/Block.tpl" fields=$petitionActivityProfile hideFieldset=true}
-  </div>
+  <div id="intro" class="crm-section">{$petition.instructions}</div>
+  <div class="crm-block crm-petition-form-block">
 
-  <div class="crm-submit-buttons">
-    {include file="CRM/common/formButtons.tpl" location="bottom"}
-  </div>
+  {if $duplicate == "confirmed"}
+    <p>
+    {ts}You have already signed this petition.{/ts}
+    </p>
+  {/if}
+  {if $duplicate == "unconfirmed"}
+    <p>{ts}You have already signed this petition but you still <b>need to verify your email address</b>.{/ts}<br/> {ts}Please check your email inbox for the confirmation email. If you don't find it, verify if it isn't in your spam folder.{/ts}</p>
+  {/if}
+  {if $duplicate}
+    <p>{ts}Thank you for your support.{/ts}</p>
+    {if $is_share}
+      {include file="CRM/Campaign/Page/Petition/SocialNetwork.tpl" petition_id=$survey_id petitionTitle=$petitionTitle}
+    {/if}
+  {else}
+    <div class="crm-section crm-petition-contact-profile">
+      {include file="CRM/UF/Form/Block.tpl" fields=$petitionContactProfile hideFieldset=true}
+    </div>
+
+    <div class="crm-section crm-petition-activity-profile">
+      {include file="CRM/UF/Form/Block.tpl" fields=$petitionActivityProfile hideFieldset=true}
+    </div>
+
+    <div class="crm-submit-buttons">
+      {include file="CRM/common/formButtons.tpl" location="bottom"}
+    </div>
+  {/if}
 {/if}
-
 </div>
-- 
2.25.1