From 34dc58e781e995eb91b7be476fb8900a976299a0 Mon Sep 17 00:00:00 2001 From: Matthew Wire Date: Thu, 20 Aug 2020 21:38:03 +0100 Subject: [PATCH] Remove unused variables from repeatTransaction --- CRM/Contribute/BAO/Contribution.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 496d64dcda..35bd4f1326 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -2613,7 +2613,7 @@ LEFT JOIN civicrm_contribution contribution ON ( componentPayment.contribution_ * @return bool|array * @throws CiviCRM_API3_Exception */ - protected static function repeatTransaction(&$contribution, &$input, $contributionParams) { + protected static function repeatTransaction(&$contribution, $input, $contributionParams) { if (!empty($contribution->id)) { return FALSE; } @@ -4498,7 +4498,7 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac ], array_intersect_key($input, array_fill_keys($inputContributionWhiteList, 1) )); - $contributionParams['payment_processor'] = $input['payment_processor'] = $paymentProcessorId; + $contributionParams['payment_processor'] = $paymentProcessorId; // If paymentProcessor is not set then the payment_instrument_id would not be correct. // not clear when or if this would occur if you encounter this please fix here & add a unit test. -- 2.25.1