From 31b49137444ac60bb2c0a4c1b8288093b3c1ed18 Mon Sep 17 00:00:00 2001 From: eileen Date: Wed, 5 Aug 2020 18:35:45 +1200 Subject: [PATCH] dev/financial#135 Remove unreachable doDirectPayment from manual processor doDirectPayment is only ever called (deprecated) when doPayment is not overriden (for quite some time now). This is unreachable & can be removed --- CRM/Core/Payment/Manual.php | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/CRM/Core/Payment/Manual.php b/CRM/Core/Payment/Manual.php index a2c7c5dd25..4c254691cc 100644 --- a/CRM/Core/Payment/Manual.php +++ b/CRM/Core/Payment/Manual.php @@ -238,25 +238,6 @@ class CRM_Core_Payment_Manual extends CRM_Core_Payment { return TRUE; } - /** - * Submit a manual payment. - * - * @param array $params - * Assoc array of input parameters for this transaction. - * - * @return array - */ - public function doDirectPayment(&$params) { - $statuses = CRM_Contribute_BAO_Contribution::buildOptions('contribution_status_id'); - if ($params['is_pay_later']) { - $result['payment_status_id'] = array_search('Pending', $statuses); - } - else { - $result['payment_status_id'] = array_search('Completed', $statuses); - } - return $result; - } - /** * Should a receipt be sent out for a pending payment. * -- 2.25.1